From: Bart Schaefer <schaefer@brasslantern.com>
To: zsh-workers@zsh.org
Subject: Re: PROMPT_SP bug with local in precmd
Date: Fri, 26 Nov 2010 18:27:34 -0800 [thread overview]
Message-ID: <101126182734.ZM27122@torch.brasslantern.com> (raw)
In-Reply-To: <20101126225316.325fa5ca@pws-pc.ntlworld.com>
On Nov 26, 10:53pm, Peter Stephenson wrote:
} Subject: Re: PROMPT_SP bug with local in precmd
}
} On Fri, 26 Nov 2010 09:38:10 -0800
} Bart Schaefer <schaefer@brasslantern.com> wrote:
} > My conclusion from this is that "foozsh: exit 1" is what you really
} > ought to be seeing all the time, and "zsh: exit 1" on its own line is a
} > side-effect of a stdio buffer never having been flushed.
}
} I think the following demonstrates the opposite, i.e. the exit message
} now always appears on a newline but as it's race prone it's hard
} to be sure.
Hmm. Now I get:
torch% setopt printexitvalue
torch% echo -n foo; false
foo%
zsh: exit 1
torch% precmd() { /bin/echo -n Hi }
torch%
torch% echo -n foo; false
foo%
zsh: exit 1
Hizsh: exit 1
torch%
Note that immediately after creating the precmd function, the "Hi" is
NOT visible. (This is with Wayne's hasxn patch as well as with your
fflush). However, it *was* output -- the prompt just backed up and
trod over it. So PROMPT_SP kicks in before precmd does, which is I
think what Wayne asserted it should do.
However with a non-builtin command in the precmd, I'm still getting
"zsh: exit 1" printed twice, so I think we're both correct -- that
is, there's *another* place where a fflush() is needed. Looks like
just after line 3188 in Src/exec.c.
With fflush() added there as well, I consistently get this:
torch% setopt printexitvalue
torch% echo -n foo; false
foozsh: exit 1
torch% precmd() { /bin/echo -n Hi }
torch% echo -n foo; false
foozsh: exit 1
torch%
Note there's now only one "zsh: exit 1" and the prompt now consistently
covers up the output from precmd.
} I hope I'm not undoing any magic with this.
Ditto.
next prev parent reply other threads:[~2010-11-27 2:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-26 11:51 Vincent Lefevre
2010-11-26 17:38 ` Bart Schaefer
2010-11-26 22:53 ` Peter Stephenson
2010-11-27 2:03 ` Wayne Davison
2010-11-27 2:27 ` Bart Schaefer [this message]
2010-11-27 17:15 ` Peter Stephenson
2010-11-28 10:35 ` Vincent Lefevre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=101126182734.ZM27122@torch.brasslantern.com \
--to=schaefer@brasslantern.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).