From: "Bart Schaefer" <schaefer@brasslantern.com>
To: Felix Rosencrantz <f_rosencrantz@yahoo.com>, zsh-workers@sunsite.dk
Subject: Re: Test failure in redirect.
Date: Mon, 4 Feb 2002 18:45:33 +0000 [thread overview]
Message-ID: <1020204184533.ZM24919@candle.brasslantern.com> (raw)
In-Reply-To: <20020131064103.12082.qmail@web10405.mail.yahoo.com>
On Jan 30, 10:41pm, Felix Rosencrantz wrote:
} Subject: Test failure in redirect.
}
} print foo >&-
} Error output:
} (eval):print:1: write error: bad file descriptor
This is of course a result of the error-checking that Clint added to
bin_print().
--- ../zsh-forge/current/Src/builtin.c Sun Jan 27 15:17:26 2002
+++ Src/builtin.c Mon Feb 4 10:43:46 2002
@@ -3074,10 +3074,12 @@
} while (*ap);
fputc(ops['N'] ? '\0' : '\n', fout);
}
- if (((fout != stdout) ? fclose(fout) : fflush(fout)) != 0) {
+ /* Testing EBADF special-cases >&- redirections */
+ if ((fout != stdout) ? (fclose(fout) != 0) :
+ (fflush(fout) != 0 && errno != EBADF)) {
zwarnnam(name, "write error: %e", NULL, errno);
ret = 1;
- }
+ }
return ret;
}
@@ -3090,11 +3092,12 @@
}
if (!(ops['n'] || nnl))
fputc(ops['N'] ? '\0' : '\n', fout);
- if (((fout != stdout) ? fclose(fout) : fflush(fout)) != 0) {
+ /* Testing EBADF special-cases >&- redirections */
+ if ((fout != stdout) ? (fclose(fout) != 0) :
+ (fflush(fout) != 0 && errno != EBADF)) {
zwarnnam(name, "write error: %e", NULL, errno);
ret = 1;
}
-
return ret;
}
@@ -3279,9 +3282,11 @@
}
zwarnnam(name, "%s: invalid directive", start, 0);
if (*c) c[1] = save;
- if (((fout != stdout) ? fclose(fout) : fflush(fout)) != 0) {
- zwarnnam(name, "write error: %e", NULL, errno);
- }
+ /* Testing EBADF special-cases >&- redirections */
+ if ((fout != stdout) ? (fclose(fout) != 0) :
+ (fflush(fout) != 0 && errno != EBADF)) {
+ zwarnnam(name, "write error: %e", NULL, errno);
+ }
return 1;
}
@@ -3345,9 +3350,11 @@
/* if there are remaining args, reuse format string */
} while (*args && args != first && !ops['r']);
- if (((fout != stdout) ? fclose(fout) : fflush(fout)) != 0) {
- zwarnnam(name, "write error: %e", NULL, errno);
- ret = 1;
+ /* Testing EBADF special-cases >&- redirections */
+ if ((fout != stdout) ? (fclose(fout) != 0) :
+ (fflush(fout) != 0 && errno != EBADF)) {
+ zwarnnam(name, "write error: %e", NULL, errno);
+ ret = 1;
}
return ret;
}
--
Bart Schaefer Brass Lantern Enterprises
http://www.well.com/user/barts http://www.brasslantern.com
Zsh: http://www.zsh.org | PHPerl Project: http://phperl.sourceforge.net
next prev parent reply other threads:[~2002-02-04 18:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-01-31 6:41 Felix Rosencrantz
2002-02-04 18:45 ` Bart Schaefer [this message]
2002-02-04 21:03 ` Zefram
2002-02-05 2:31 ` Bart Schaefer
2002-02-05 2:46 ` Zefram
2002-02-05 5:22 ` Bart Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1020204184533.ZM24919@candle.brasslantern.com \
--to=schaefer@brasslantern.com \
--cc=f_rosencrantz@yahoo.com \
--cc=zsh-workers@sunsite.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).