problem with quoting in completion function

problem with quoting in completion function

[Borsenkow Andrej]

This applies to 4.0.4 as distributed by Mandrake.

I spent some time trying to understand why the following (suggested by
Sven) does not work:

 compset -P "*,"
 all_sources=( ${all_sources:#(${~IPREFIX//,/|})} )

The intention being to remove already present matches (separated by
comma) from list of possible matches.

It turned out, completion internally quotes IPREFIX, and in my case it
had spaces inside (like "Installation CD") so pattern never matched.
I.e. it tried to match

Installation\ CD

against

Installation CD

If this quoting is intentional it does not seem to be described in
documentation. But I still do not like it, it comes unexpected enough.
It makes it impossible to simply  compare strings.

I had to finally do

    compset -P "*,"
    for i in ${(s:,:)IPREFIX}; do
        eval "all_sources=( \${all_sources:#$i} )"
    done

but that is just ugly.

-andrej

Re: problem with quoting in completion function

[Borsenkow Andrej]

В Вск, 14.04.2002, в 00:16, Borsenkow Andrej написал:
> 
> It turned out, completion internally quotes IPREFIX,

Of course it does not quote IPREFIX. It quotes word inserted in command
line that becomes IPREFIX on next try.

And of course it could be quoted by user in different way.

Is there any general way inside completion to "dequote" word from
command line? 

-andrej

Re: problem with quoting in completion function

[Bart Schaefer]

On Apr 14, 12:16am, Borsenkow Andrej wrote:
}
} I spent some time trying to understand why the following (suggested by
} Sven) does not work:
} 
}  compset -P "*,"
}  all_sources=( ${all_sources:#(${~IPREFIX//,/|})} )

On Apr 14, 12:23am, Borsenkow Andrej wrote:
}
} > It turned out, completion internally quotes IPREFIX,
} 
} Of course it does not quote IPREFIX. It quotes word inserted in command
} line that becomes IPREFIX on next try.
} 
} Is there any general way inside completion to "dequote" word from
} command line? 

I was going to compare this to Jeremy Dolan's bug from the other day, but
after a bit of thought I see that it isn't, really -- the quoting of the
IPREFIX theoretically shouldn't matter, because it's ignored, after all.

I wonder if ${(Q)IPREFIX} would do what you need?  What should happen if
the ignored prefix contains e.g. an unmatched single-quote?  Probably you
should examine $compstate[all_quotes] to decide what to do.

Here's a different example of Jeremy's bug:

schaefer<512> ls "foo\<TAB>
Completing corrections
foo\!baz   foo\!bar 
Completing original
foo\\

Note that it thinks the original string has two backslashes, and only
supplies the other two choices as corrections.

In that case, the completion internals really did quote $PREFIX.  It's
already got both backslashes by the time _main_complete starts calling
the completers.  A quick peek at callcompfunc() shows that the prefix
gets passed through multiquote() in all cases except math expressions.
Again it might be possible to do something different depending on the
quoting state, but in this case it'd have to be in the C code.

-- 
Bart Schaefer                                 Brass Lantern Enterprises
http://www.well.com/user/barts              http://www.brasslantern.com

Zsh: http://www.zsh.org | PHPerl Project: http://phperl.sourceforge.net   

Re: problem with quoting in completion function

[Sven Wischnowsky]

Borsenkow Andrej wrote:

> 
> This applies to 4.0.4 as distributed by Mandrake.
> 
> I spent some time trying to understand why the following (suggested by
> Sven) does not work:
> 
>  compset -P "*,"
>  all_sources=( ${all_sources:#(${~IPREFIX//,/|})} )

Bart already suggested using foo=( ${foo:#(${(Q)~IPREFIX//,/|})} ),
which works for me, even inside quotes etc., so nothing new here.

> ...
> 
> If this quoting is intentional it does not seem to be described in
> documentation. But I still do not like it, it comes unexpected enough.
> It makes it impossible to simply  compare strings.

What do you mean by `unexpected'? It has always been this way (module
a couple of bugs, as you know, having been here all the time ;-). And
the string is moved from $PREFIX to $IPREFIX without being changed, so
what could be more expectable?

And maybe you remember, that all this quoting stuff (which I won't
touch again without better reasons) always was a bit of a compromise,
being a very complicated matter -- nowadays even with the possibility
of nested quoting levels and whatnot. And still, it's cleaner now than
it was in previous stable versions.


Bye
  Sven

-- 
Sven Wischnowsky                          wischnow@berkom.de