From: "Bart Schaefer" <schaefer@brasslantern.com>
To: zsh-workers@sunsite.dk (Zsh hackers list)
Subject: PATCH (revised) Re: Parameter error trapped too late
Date: Wed, 18 Sep 2002 15:07:00 +0000 [thread overview]
Message-ID: <1020918150700.ZM10605@candle.brasslantern.com> (raw)
In-Reply-To: <11934.1032191960@csr.com>
On Sep 16, 4:59pm, Peter Stephenson wrote:
} Subject: Re: PATCH Re: Parameter error trapped too late
}
} > schaefer<501> typeset 30=foo
} > zsh: not an identifier: 30
} >
} > We could refine the error message if that's desirable, but bash2 gives a
} > similar "not a valid identifier" in that example.
}
} Yes, but bash doesn't allow `30=foo' as a normal assignment whereas zsh
} does, so I think a different error message here might be better.
} Something like `identifier not allowed in this context'.
How about the following, then. Is there any reason that zerrnam() was not
already being used for the "not an identifier" complaint? To pretend that
the error came from the parser, perhaps? Bash2's error in this same case
includes the name of the command.
Index: builtin.c
===================================================================
RCS file: /extra/cvsroot/zsh/zsh-4.0/Src/builtin.c,v
retrieving revision 1.17
diff -c -r1.17 builtin.c
--- builtin.c 12 Sep 2002 07:59:07 -0000 1.17
+++ builtin.c 18 Sep 2002 14:49:06 -0000
@@ -1909,7 +1909,7 @@
"%s: array elements must be scalar", pname, 0);
return NULL;
}
- } else if (isident(pname)) {
+ } else if (isident(pname) && !idigit(*pname)) {
/*
* Create a new node for a parameter with the flags in `on' minus the
* readonly flag
@@ -1918,7 +1918,10 @@
DPUTS(!pm, "BUG: parameter not created");
pm->ct = auxlen;
} else {
- zerr("not an identifier: %s", pname, 0);
+ if (isident(pname))
+ zerrnam(cname, "not valid in this context: %s", pname, 0);
+ else
+ zerrnam(cname, "not an identifier: %s", pname, 0);
return NULL;
}
--
Bart Schaefer Brass Lantern Enterprises
http://www.well.com/user/barts http://www.brasslantern.com
Zsh: http://www.zsh.org | PHPerl Project: http://phperl.sourceforge.net
next prev parent reply other threads:[~2002-09-18 15:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-09-16 14:03 Peter Stephenson
2002-09-16 15:00 ` PATCH " Bart Schaefer
2002-09-16 15:59 ` Peter Stephenson
2002-09-18 15:07 ` Bart Schaefer [this message]
2002-09-18 17:47 ` PATCH (revised) " Peter Stephenson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1020918150700.ZM10605@candle.brasslantern.com \
--to=schaefer@brasslantern.com \
--cc=zsh-workers@sunsite.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).