From: "Bart Schaefer" <schaefer@brasslantern.com>
To: zsh-workers@sunsite.dk
Cc: 171716@bugs.debian.org, phil@fifi.org
Subject: Re: GNU nohup oddness
Date: Sat, 7 Dec 2002 17:43:23 +0000 [thread overview]
Message-ID: <1021207174323.ZM11632@candle.brasslantern.com> (raw)
In-Reply-To: <20021207152412.GA15901@dman.com>
On Dec 7, 10:24am, Clint Adams wrote:
} Subject: Re: GNU nohup oddness
}
} > (3) In Src/init.c:init_signals(), zsh explicitly installs a SIGHUP
} > handler, even in non-interactive shells. It has done so for a
} > very long time -- as far back as recorded in my CVS of 3.0.x,
} > which means prior to 27-Jun-97.
}
} So is this the right thing to do?
[Patch moves install_handler(SIGHUP) call to `if (interact)' block]
I'm not certain. Probably more correct would be something like:
@@ -870,7 +897,8 @@
signal_ignore(SIGQUIT);
#endif
- install_handler(SIGHUP);
+ if (signal_ignore(SIGHUP) != SIG_IGN)
+ install_handler(SIGHUP);
install_handler(SIGCHLD);
#ifdef SIGWINCH
install_handler(SIGWINCH);
Or maybe even:
@@ -870,7 +897,10 @@
signal_ignore(SIGQUIT);
#endif
- install_handler(SIGHUP);
+ if (signal_ignore(SIGHUP) == SIG_IGN)
+ opts[HUP] = 0;
+ else
+ install_handler(SIGHUP);
install_handler(SIGCHLD);
#ifdef SIGWINCH
install_handler(SIGWINCH);
Does anybody else have an opinion?
--
Bart Schaefer Brass Lantern Enterprises
http://www.well.com/user/barts http://www.brasslantern.com
Zsh: http://www.zsh.org | PHPerl Project: http://phperl.sourceforge.net
next prev parent reply other threads:[~2002-12-07 17:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-12-06 0:30 Clint Adams
2002-12-06 10:14 ` Bart Schaefer
2002-12-07 15:24 ` Clint Adams
2002-12-07 17:43 ` Bart Schaefer [this message]
2002-12-09 18:00 ` Peter Stephenson
2002-12-12 4:09 ` Bart Schaefer
2002-12-12 10:39 ` Peter Stephenson
2002-12-12 15:33 ` Bart Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1021207174323.ZM11632@candle.brasslantern.com \
--to=schaefer@brasslantern.com \
--cc=171716@bugs.debian.org \
--cc=phil@fifi.org \
--cc=zsh-workers@sunsite.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).