From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26866 invoked from network); 4 Jun 2003 17:21:54 -0000 Received: from sunsite.dk (130.225.247.90) by ns1.primenet.com.au with SMTP; 4 Jun 2003 17:21:54 -0000 Received: (qmail 15415 invoked by alias); 4 Jun 2003 17:21:48 -0000 Mailing-List: contact zsh-workers-help@sunsite.dk; run by ezmlm Precedence: bulk X-No-Archive: yes X-Seq: 18606 Received: (qmail 15406 invoked from network); 4 Jun 2003 17:21:47 -0000 Received: from localhost (HELO sunsite.dk) (127.0.0.1) by localhost with SMTP; 4 Jun 2003 17:21:47 -0000 X-MessageWall-Score: 0 (sunsite.dk) Received: from [4.64.233.9] by sunsite.dk (MessageWall 1.0.8) with SMTP; 4 Jun 2003 17:21:46 -0000 Received: (from schaefer@localhost) by candle.brasslantern.com (8.11.6/8.11.6) id h54HLjs18215 for zsh-workers@sunsite.dk; Wed, 4 Jun 2003 10:21:45 -0700 From: Bart Schaefer Message-Id: <1030604172144.ZM18214@candle.brasslantern.com> Date: Wed, 4 Jun 2003 17:21:44 +0000 In-Reply-To: <5.2.1.1.0.20030604050554.025f6070@pop1.mail.com> Comments: In reply to Dirus "Re: prompt themes" (Jun 4, 6:01am) References: <5.2.1.1.0.20030531101708.025fcc78@valenzud.inbox.email.arizona.edu> <5.2.1.1.0.20030604050554.025f6070@pop1.mail.com> X-Mailer: Z-Mail (5.0.0 30July97) To: zsh-workers@sunsite.dk Subject: Re: prompt themes MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii On Jun 4, 6:01am, Dirus wrote: } } > It should } >probably also do a preview even if there isn't a prompt_X_preview function } >- there isn't for most. } } The problem here is we don't know how many parameters the themes } take. If the theme doesn't work with zero parameters, it's broken. If there is no preview function, don't try to guess at parameters; preview whatever the defaults are. [Regarding help] } } I see your point. Using cat is pretty straight forward, and I am happy } to leave it alone. :) The only advantage to using $REPLY here would be } that if you intended on using the help string without directly echoing } it to the screen. If you want a description that isn't meant to be displayed as-is, add another one; don't overload use of the help function. See prompt_bart_help in prompt_bart_setup for a good reason why not. } >There's probably quite a few aspects of the prompt theming that could } >be improved. Making colour schemes independent of specific fonts would } >be one example. } } Maybe you mean making color schemes independent of specific themes? No, he means exactly what he said. There are some fonts that have half- tone special characters, and some of the themes rely on those fonts to get a "fade" effect from one color to another. } One problem I noticed the other day is if one prompt sets PS3, PS4, or } RPS1, then those vars won't get reset when changing prompts, even when } setting the prompt to "off". It's a general shortcoming that themes only change the parts of the prompt that they're interested in; "off" is just another theme with a silly name. To really have "prompt off" mean what it seems to mean, the theme system would have to save and restore the original values of all the variables. } There do seem to be some problems with the distributed themes descriptions } too, for example adam1 (correct me if I'm wrong) says it requires an 8 bit } font when it doesn't. The usual case of the doc not keeping pace with other changes. It did require an 8bit font at one time.