From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 7444 invoked from network); 24 Jun 2020 10:47:32 -0000 Received: from ns1.primenet.com.au (HELO primenet.com.au) (203.24.36.2) by inbox.vuxu.org with ESMTPUTF8; 24 Jun 2020 10:47:32 -0000 Received: (qmail 5485 invoked by alias); 24 Jun 2020 10:47:24 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: Sender: zsh-workers@zsh.org X-Seq: 46110 Received: (qmail 25451 invoked by uid 1010); 24 Jun 2020 10:47:23 -0000 X-Qmail-Scanner-Diagnostics: from smtpq2.tb.ukmail.iss.as9143.net by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.102.3/25850. spamassassin: 3.4.4. Clear:RC:0(212.54.57.97):SA:0(-2.7/5.0):. Processed in 0.692212 secs); 24 Jun 2020 10:47:23 -0000 X-Envelope-From: p.w.stephenson@ntlworld.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: pass (ns1.primenet.com.au: SPF record at _mailcloud.virginmedia.com designates 212.54.57.97 as permitted sender) X-Env-Mailfrom: p.w.stephenson@ntlworld.com X-Env-Rcptto: zsh-workers@zsh.org X-SourceIP: 172.25.160.154 X-CNFS-Analysis: v=2.3 cv=Lf2nFgXi c=1 sm=1 tr=0 a=0gQdd85zlVecdCXELxTKIw==:117 a=KEnZaF_ea6UA:10 a=IkcTkHD0fZMA:10 a=DoY9bV0jb9AA:10 a=NLZqzBF-AAAA:8 a=BrDiTsk0AAAA:8 a=lP03_QR8WUazyXvI_NYA:9 a=QEXdDO2ut3YA:10 a=wW_WBVUImv98JQXhvVPZ:22 a=fK1jZSgjKPFatbRoI9mg:22 X-Authenticated-Sender: p.w.stephenson@ntlworld.com Date: Wed, 24 Jun 2020 11:46:49 +0100 (BST) From: Peter Stephenson To: Zsh workers Message-ID: <1037903351.49961.1592995609930@mail2.virginmedia.com> In-Reply-To: <1131758486.49253.1592994514109@mail2.virginmedia.com> References: <20200515085324.63c6325f@tarpaulin.shahaf.local2> <20200606081909.33d488c5@tarpaulin.shahaf.local2> <99116-1591744033.948885@zagI.gwnq.OfJE> <20200610134459.514b0a3d@tarpaulin.shahaf.local2> <86219-1592947387.142438@emcj.0STP.JFZv> <1131758486.49253.1592994514109@mail2.virginmedia.com> Subject: Re: SH_FILE_EXPANSION broken with process substitution MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Priority: 3 Importance: Medium X-Mailer: Open-Xchange Mailer v7.8.4-Rev70 X-Originating-IP: 165.225.81.56 X-Originating-Client: open-xchange-appsuite X-CMAE-Envelope: MS4wfOge38KaAF0temaYz2Og+luz2oXTiYx9uECyiyZUGQBrlCQSVdy3OWrBL8OgZRAjsDNB5+gWsUQ0B+xtV+qRvGIAL4UDtEfE160zsLpi5nVtm6lHWqKK iQUJCqixxMGNuToJ6G1ngWMA3KwQjsnIwh5TtCxqEvs6tMqScuDMBt6G+RGjovzyFvX84+8z3RqhO2Ns/Im2SVqTqslRW6ruTPQ= > On 24 June 2020 at 11:28 Peter Stephenson wrote: > > On 23 June 2020 at 22:23 Oliver Kiddle wrote: > > Following on from the gpg completion breakage, it seems this option has > > been broken when used in combination with EQUALS. > > > > This got broken in 35a8612 (workers/26042), released in 4.3.10: > > zsh -df --shfileexpansion -c ': =(echo hi)' Same but with test... D03 already tests that process substitution is implemented, so it to be safe to test the result is fully functional. pws diff --git a/Src/subst.c b/Src/subst.c index 90b5fc121..ed3f4a82b 100644 --- a/Src/subst.c +++ b/Src/subst.c @@ -796,7 +796,7 @@ filesubstr(char **namptr, int assign) *namptr = dyncat(hom, ptr); return 1; } - } else if (*str == Equals && isset(EQUALS) && str[1]) { /* =foo */ + } else if (*str == Equals && isset(EQUALS) && str[1] && str[1] != Inpar) { /* =foo */ char *expn = equalsubstr(str+1, assign, isset(NOMATCH)); if (expn) { *namptr = expn; diff --git a/Test/D03procsubst.ztst b/Test/D03procsubst.ztst index 8cf4e2a7f..68a68ef6e 100644 --- a/Test/D03procsubst.ztst +++ b/Test/D03procsubst.ztst @@ -156,3 +156,7 @@ procfunc <(echo argument) 0:With /proc/self file descriptors must not be tidied up too early >argument + + $ZTST_testdir/../Src/zsh -df -o shfileexpansion -c 'cat =(echo hi)' +0:EQUALS expansion followed by =(...) (sh ordering) should work +>hi