Use of ${words[0]} in completion functions

Use of ${words[0]} in completion functions

[Bart Schaefer]

I just noticed that a couple of completion functions use ${words[0]} as
the command name.  That's a little misleading -- and maybe even a bug
waiting to happen -- because $_comp_options contains NO_ksharrays, and
neither of these functions resets it.

Completion/Unix/Type/_perl_modules:33:  local perl=${words[0]%doc} perl_modules

Completion/bashcompinit:123:	$OPTARG "${words[0]}" "${words[CURRENT-1]}" "${words[CURRENT-2]}"

Re: Use of ${words[0]} in completion functions

[Oliver Kiddle]

On 11 Jan, Bart wrote:
> I just noticed that a couple of completion functions use ${words[0]} as
> the command name.  That's a little misleading -- and maybe even a bug
> waiting to happen -- because $_comp_options contains NO_ksharrays, and
> neither of these functions resets it.
> 
> Completion/Unix/Type/_perl_modules:33:  local perl=${words[0]%doc} perl_modules

I'd agree that's potentially misleading. Patch below.

> Completion/bashcompinit:123:	$OPTARG "${words[0]}" "${words[CURRENT-1]}" "${words[CURRENT-2]}"

There is an `emulate -L sh' in the function here so that looks right to
me.

Oliver

Index: Completion/Unix/Type/_perl_modules
===================================================================
RCS file: /cvsroot/zsh/zsh/Completion/Unix/Type/_perl_modules,v
retrieving revision 1.2
diff -u -r1.2 _perl_modules
--- Completion/Unix/Type/_perl_modules	16 Apr 2002 07:48:46 -0000	1.2
+++ Completion/Unix/Type/_perl_modules	14 Jan 2004 15:40:46 -0000
@@ -30,7 +30,7 @@
       _perl_modules_caching_policy
   fi
 
-  local perl=${words[0]%doc} perl_modules
+  local perl=${words[1]%doc} perl_modules
   if whence $perl >/dev/null; then
     perl_modules=_${${perl//[^[:alnum:]]/_}#_}_modules
   elif (( ${+commands[perl]} )); then