Coredump in test B02 as of 2004-01-13

Coredump in test B02 as of 2004-01-13

[Vin Shelton]

Greetings,

On my SunOS systems at work I'm seeing the following failure in the
testsuite when running against a build of 2004-01-13:

(Partial result from 'ZTST_verbose=2 make TESTNUM=B02 check')

Running test: Stress test: all parameters are local and unset, using -m
ZTST_test: expecting status: 0
Input: /tmp/zsh.ztst.in.722, output: /tmp/zsh.ztst.out.722, error: /tmp/zsh.ztst.terr.722
ZTST_execchunk: status 0
ZTST_test: test produced standard output:
scalar a r y
ZTST_test: and standard error:

Test successful.
ZTST_test: looking for new test
ZTST_test: examining line:

ZTST_test: examining line:
 # The first declare works around the "not an identifier" bug with -h
ZTST_getchunk: read code chunk:
 # The first declare works around the "not an identifier" bug with -h
 declare \! \# \$ \* - \? @ 0
 typeset -h +g -m \*
 unset -m \*
 integer i=9
 float -H f=9
 declare -t scalar
 declare -H -a array
 typeset
 typeset +
ZTST_test: examining line:
>array local array
ZTST_getredir: read redir for '>':
array local array
float local f
integer local i=9
local tagged scalar=''
array local array
float local f
integer local i
local tagged scalar
ZTST_test: examining line:

Running test: Parameter hiding and tagging, printing types and values
ZTST_test: expecting status: 0
Input: /tmp/zsh.ztst.in.722, output: /tmp/zsh.ztst.out.722, error: /tmp/zsh.ztst.terr.722
Segmentation Fault - core dumped
make: [check] Error 139 (ignored)
rm -rf Modules .zcompdump


The 2004-01-12 build did not show this coredump, IIRC.  

HTH,
  Vin

-- 
In a minute there is time
For decisions and revisions which a minute will reverse.         T.S. Eliot
[URL: http://www.cs.amherst.edu/~ccm/prufrock.html]

Re: Coredump in test B02 as of 2004-01-13

[Bart Schaefer]

On Jan 14, 11:05am, Vin Shelton wrote:
}
} On my SunOS systems at work I'm seeing the following failure in the
} testsuite when running against a build of 2004-01-13:
} 
} The 2004-01-12 build did not show this coredump, IIRC.  

I'd suspect zsh-workers/19361.

I don't get a coredump, but oddly I do get:

make[1]: [check] Error 139 (ignored)

which I'm fairly sure I did not used to get.

Re: Coredump in test B02 as of 2004-01-13

[Peter Stephenson]

Vin Shelton wrote:
> Greetings,
> 
> On my SunOS systems at work I'm seeing the following failure in the
> testsuite when running against a build of 2004-01-13:

Reduces to:

  unset argv
  print $#

Right idea, wrong number of ampersands.

Index: Src/params.c
===================================================================
RCS file: /cvsroot/zsh/zsh/Src/params.c,v
retrieving revision 1.75
diff -u -r1.75 params.c
--- Src/params.c	12 Jan 2004 12:09:12 -0000	1.75
+++ Src/params.c	15 Jan 2004 10:50:29 -0000
@@ -2585,7 +2585,7 @@
      * ways which need to be set to NULL.  We can't do this
      * with user tied variables since we can leak memory.
      */
-    if ((pm->flags & PM_SPECIAL) & !x)
+    if ((pm->flags & PM_SPECIAL) && !x)
 	*dptr = mkarray(NULL);
     else
 	*dptr = x;

-- 
Peter Stephenson <pws@csr.com>                  Software Engineer
CSR Ltd., Science Park, Milton Road,
Cambridge, CB4 0WH, UK                          Tel: +44 (0)1223 692070


**********************************************************************
This email and any files transmitted with it are confidential and
intended solely for the use of the individual or entity to whom they
are addressed. If you have received this email in error please notify
the system manager.

This footnote also confirms that this email message has been swept by
MIMEsweeper for the presence of computer viruses.

www.mimesweeper.com
**********************************************************************

Re: Coredump in test B02 as of 2004-01-13

[Vin Shelton]

Peter Stephenson <pws@csr.com> writes:

> Vin Shelton wrote:
>> Greetings,
>> 
>> On my SunOS systems at work I'm seeing the following failure in the
>> testsuite when running against a build of 2004-01-13:
>
> Reduces to:
>
>   unset argv
>   print $#
>
> Right idea, wrong number of ampersands.
>
> Index: Src/params.c
> ===================================================================
> RCS file: /cvsroot/zsh/zsh/Src/params.c,v
> retrieving revision 1.75
> diff -u -r1.75 params.c
> --- Src/params.c	12 Jan 2004 12:09:12 -0000	1.75
> +++ Src/params.c	15 Jan 2004 10:50:29 -0000
> @@ -2585,7 +2585,7 @@
>       * ways which need to be set to NULL.  We can't do this
>       * with user tied variables since we can leak memory.
>       */
> -    if ((pm->flags & PM_SPECIAL) & !x)
> +    if ((pm->flags & PM_SPECIAL) && !x)
>  	*dptr = mkarray(NULL);
>      else
>  	*dptr = x;
>

Yes, this fixes the coredump.  Thanks, Peter!

  - Vin