* Segfault completing in minibuffer
@ 2005-03-11 6:26 Bart Schaefer
2005-03-11 10:30 ` Peter Stephenson
0 siblings, 1 reply; 2+ messages in thread
From: Bart Schaefer @ 2005-03-11 6:26 UTC (permalink / raw)
To: zsh-workers
The latest CVS segfaults when completing at the minibuffer prompt for
execute-named-cmd, whether or not unicode support is enabled.
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Segfault completing in minibuffer
2005-03-11 6:26 Segfault completing in minibuffer Bart Schaefer
@ 2005-03-11 10:30 ` Peter Stephenson
0 siblings, 0 replies; 2+ messages in thread
From: Peter Stephenson @ 2005-03-11 10:30 UTC (permalink / raw)
To: zsh-workers
Bart Schaefer wrote:
> The latest CVS segfaults when completing at the minibuffer prompt for
> execute-named-cmd, whether or not unicode support is enabled.
Another two uses of unmetafy need the string copying. Probably an
allocating version of unmetafy would be more efficient.
Index: Src/Zle/zle_misc.c
===================================================================
RCS file: /cvsroot/zsh/zsh/Src/Zle/zle_misc.c,v
retrieving revision 1.21
diff -u -r1.21 zle_misc.c
--- Src/Zle/zle_misc.c 7 Mar 2005 11:11:27 -0000 1.21
+++ Src/Zle/zle_misc.c 11 Mar 2005 10:28:08 -0000
@@ -911,8 +911,9 @@
showinglist = 0;
zmult = zmultsav;
} else if (!nextnode(firstnode(namedcmdll))) {
- ZLE_STRING_T ztmp = stringaszleline(peekfirst(namedcmdll),
- &len, NULL);
+ char *peekstr = ztrdup(peekfirst(namedcmdll));
+ ZLE_STRING_T ztmp = stringaszleline(peekstr, &len, NULL);
+ zsfree(peekstr);
ZS_memcpy(ptr = cmdbuf, ztmp, len);
ptr += len;
free(ztmp);
@@ -920,8 +921,9 @@
goto unambiguous;
} else {
int ltmp;
- ZLE_STRING_T ztmp = stringaszleline(peekfirst(namedcmdll),
- <mp, NULL);
+ char *peekstr = ztrdup(peekfirst(namedcmdll));
+ ZLE_STRING_T ztmp = stringaszleline(peekstr, <mp, NULL);
+ zsfree(peekstr);
ZS_memcpy(cmdbuf, ztmp, ltmp);
free(ztmp);
ptr = cmdbuf + namedcmdambig;
--
Peter Stephenson <pws@csr.com> Software Engineer
CSR PLC, Churchill House, Cambridge Business Park, Cowley Road
Cambridge, CB4 0WZ, UK Tel: +44 (0)1223 692070
**********************************************************************
This email and any files transmitted with it are confidential and
intended solely for the use of the individual or entity to whom they
are addressed. If you have received this email in error please notify
the system manager.
**********************************************************************
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2005-03-11 10:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-03-11 6:26 Segfault completing in minibuffer Bart Schaefer
2005-03-11 10:30 ` Peter Stephenson
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).