From: Bart Schaefer <schaefer@brasslantern.com>
To: Zsh hackers list <zsh-workers@sunsite.dk>
Subject: Re: PATCH: zle TODOs etc.
Date: Sat, 26 Mar 2005 17:14:22 +0000 [thread overview]
Message-ID: <1050326171422.ZM19516@candle.brasslantern.com> (raw)
In-Reply-To: <20050323003652.GA11877@scowler.net>
On Mar 22, 7:36pm, Clint Adams wrote:
}
} Is this the right way to go about this?
}
} +mod_export void
} +wordcharshook(void)
It looks OK to me, though you should probably wait for another opinion,
as I'm not really the expert on this part of the code (maybe no one is).
Two comments:
I suggest avoiding the term "hook" in this context, because that has a
specific meaning in the zsh code (see the HOOKDEF macro) and tweaking
the value of wordchars really doesn't fit that usage.
I'd move the assignment from the /* Set up editor entry points */ section
down to the /* miscellaneous initialisations */ section, as you're not
really defining a new entry point.
next prev parent reply other threads:[~2005-03-26 17:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-21 1:39 Src/Zle/zle_word.c iword debacle Clint Adams
2005-03-21 2:09 ` Bart Schaefer
2005-02-25 14:46 ` PATCH: zle TODOs etc Peter Stephenson
2005-03-23 0:36 ` Clint Adams
2005-03-26 17:14 ` Bart Schaefer [this message]
2005-04-05 20:25 ` Clint Adams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1050326171422.ZM19516@candle.brasslantern.com \
--to=schaefer@brasslantern.com \
--cc=zsh-workers@sunsite.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).