From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28968 invoked from network); 26 Mar 2005 17:14:37 -0000 Received: from news.dotsrc.org (HELO a.mx.sunsite.dk) (130.225.247.88) by ns1.primenet.com.au with SMTP; 26 Mar 2005 17:14:37 -0000 Received: (qmail 24203 invoked from network); 26 Mar 2005 17:14:31 -0000 Received: from sunsite.dk (130.225.247.90) by a.mx.sunsite.dk with SMTP; 26 Mar 2005 17:14:31 -0000 Received: (qmail 28001 invoked by alias); 26 Mar 2005 17:14:29 -0000 Mailing-List: contact zsh-workers-help@sunsite.dk; run by ezmlm Precedence: bulk X-No-Archive: yes X-Seq: 21065 Received: (qmail 27988 invoked from network); 26 Mar 2005 17:14:28 -0000 Received: from news.dotsrc.org (HELO a.mx.sunsite.dk) (130.225.247.88) by sunsite.dk with SMTP; 26 Mar 2005 17:14:28 -0000 Received: (qmail 23955 invoked from network); 26 Mar 2005 17:14:28 -0000 Received: from vms042pub.verizon.net (206.46.252.42) by a.mx.sunsite.dk with SMTP; 26 Mar 2005 17:14:24 -0000 Received: from candle.brasslantern.com ([4.11.1.68]) by vms042.mailsrvcs.net (Sun Java System Messaging Server 6.2 HotFix 0.04 (built Dec 24 2004)) with ESMTPA id <0IDY00B68YJZ9IS3@vms042.mailsrvcs.net> for zsh-workers@sunsite.dk; Sat, 26 Mar 2005 11:14:24 -0600 (CST) Received: from candle.brasslantern.com (IDENT:schaefer@localhost [127.0.0.1]) by candle.brasslantern.com (8.12.11/8.12.11) with ESMTP id j2QHEMoO019518 for ; Sat, 26 Mar 2005 09:14:23 -0800 Received: (from schaefer@localhost) by candle.brasslantern.com (8.12.11/8.12.11/Submit) id j2QHEM1F019517 for zsh-workers@sunsite.dk; Sat, 26 Mar 2005 09:14:22 -0800 Date: Sat, 26 Mar 2005 17:14:22 +0000 From: Bart Schaefer Subject: Re: PATCH: zle TODOs etc. In-reply-to: <20050323003652.GA11877@scowler.net> To: Zsh hackers list Message-id: <1050326171422.ZM19516@candle.brasslantern.com> MIME-version: 1.0 X-Mailer: Z-Mail (5.0.0 30July97) Content-type: text/plain; charset=us-ascii References: <20050321013910.GA32327@scowler.net> <1050321020913.ZM11750@candle.brasslantern.com> <200502251446.j1PEkID6019392@news01.csr.com> <20050323003652.GA11877@scowler.net> Comments: In reply to Clint Adams "Re: PATCH: zle TODOs etc." (Mar 22, 7:36pm) X-Spam-Checker-Version: SpamAssassin 3.0.2 on a.mx.sunsite.dk X-Spam-Level: X-Spam-Status: No, score=-2.6 required=6.0 tests=AWL,BAYES_00 autolearn=ham version=3.0.2 X-Spam-Hits: -2.6 On Mar 22, 7:36pm, Clint Adams wrote: } } Is this the right way to go about this? } } +mod_export void } +wordcharshook(void) It looks OK to me, though you should probably wait for another opinion, as I'm not really the expert on this part of the code (maybe no one is). Two comments: I suggest avoiding the term "hook" in this context, because that has a specific meaning in the zsh code (see the HOOKDEF macro) and tweaking the value of wordchars really doesn't fit that usage. I'd move the assignment from the /* Set up editor entry points */ section down to the /* miscellaneous initialisations */ section, as you're not really defining a new entry point.