zsh-workers
 help / color / mirror / code / Atom feed
From: Bart Schaefer <schaefer@brasslantern.com>
To: zsh-workers@sunsite.dk
Subject: Re: replacement slowdown
Date: Sat, 23 Apr 2005 03:14:22 +0000	[thread overview]
Message-ID: <1050423031422.ZM3881@candle.brasslantern.com> (raw)
In-Reply-To: <20050422232316.GA27665@scowler.net>

On Apr 22,  7:23pm, Clint Adams wrote:
}
} ${(f)"$(</tmp/blah)"//,/x}
} 
} is much slower (23 secs vs. 0.8 secs) in 4.2.2 than it was in 4.2.1

This coincides with the change to introduce the "gsu" structure for
storing functions that perform the get/set/unset of parameters, and
to the addition of the gettimeofday() call in zfork().

Also to the change from times() to getrusage() for timing child jobs,
and to some changes in pattern matching to handle metafied strings
properly:

+       * 20522: Src/glob.c, Test/D02glob.ztst: must-match optimisation
+       was broken for pattern substitutions in parameters.

+       * 20500: Misc/globtests, Src/glob.c, Src/pattern.c, Src/zsh.h,
+       Src/Zle/complist.c, Test/D02glob.ztst: Use unmetafied strings
+       in patterns more;

+       * 20490: Src/pattern.c, Src/zsh.h: use lengths for test strings in
+       patterns instead of null termination.

Any or all of those could be contributing to slowness in the example you
gave.  Someone will have to run both versions through a profiler.

BTW, did you check that both builds used the same compiler optimization
settings?


  reply	other threads:[~2005-04-23  3:14 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-04-22 23:23 Clint Adams
2005-04-23  3:14 ` Bart Schaefer [this message]
2005-04-23  3:19   ` Clint Adams
2005-04-23 16:07     ` Bart Schaefer
2005-04-23 16:26       ` Clint Adams
2005-04-23 17:12         ` Bart Schaefer
2005-04-24  0:33           ` Peter Stephenson
2005-04-24  0:47           ` PATCH: " Bart Schaefer
2005-04-24  3:32             ` Bart Schaefer
2005-04-24 16:46               ` Bart Schaefer
2005-04-23 16:25     ` Bart Schaefer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1050423031422.ZM3881@candle.brasslantern.com \
    --to=schaefer@brasslantern.com \
    --cc=zsh-workers@sunsite.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).