From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20580 invoked from network); 4 May 2005 14:36:00 -0000 Received: from news.dotsrc.org (HELO a.mx.sunsite.dk) (130.225.247.88) by ns1.primenet.com.au with SMTP; 4 May 2005 14:36:00 -0000 Received: (qmail 43861 invoked from network); 4 May 2005 14:35:52 -0000 Received: from sunsite.dk (130.225.247.90) by a.mx.sunsite.dk with SMTP; 4 May 2005 14:35:52 -0000 Received: (qmail 23731 invoked by alias); 4 May 2005 14:35:49 -0000 Mailing-List: contact zsh-workers-help@sunsite.dk; run by ezmlm Precedence: bulk X-No-Archive: yes X-Seq: 21229 Received: (qmail 23720 invoked from network); 4 May 2005 14:35:48 -0000 Received: from news.dotsrc.org (HELO a.mx.sunsite.dk) (130.225.247.88) by sunsite.dk with SMTP; 4 May 2005 14:35:48 -0000 Received: (qmail 43658 invoked from network); 4 May 2005 14:35:48 -0000 Received: from vms046pub.verizon.net (206.46.252.46) by a.mx.sunsite.dk with SMTP; 4 May 2005 14:35:41 -0000 Received: from candle.brasslantern.com ([4.11.1.68]) by vms046.mailsrvcs.net (Sun Java System Messaging Server 6.2 HotFix 0.04 (built Dec 24 2004)) with ESMTPA id <0IFY007NRZ7FXYX0@vms046.mailsrvcs.net> for zsh-workers@sunsite.dk; Wed, 04 May 2005 09:35:40 -0500 (CDT) Received: from candle.brasslantern.com (IDENT:schaefer@localhost [127.0.0.1]) by candle.brasslantern.com (8.12.11/8.12.11) with ESMTP id j44EZcbw029990 for ; Wed, 04 May 2005 07:35:38 -0700 Received: (from schaefer@localhost) by candle.brasslantern.com (8.12.11/8.12.11/Submit) id j44EZcAx029989 for zsh-workers@sunsite.dk; Wed, 04 May 2005 07:35:38 -0700 Date: Wed, 04 May 2005 14:35:37 +0000 From: Bart Schaefer Subject: Compiling without yodl (Re: localtraps) In-reply-to: <13894.1115198893@csr.com> To: Zsh hackers list Message-id: <1050504143537.ZM29988@candle.brasslantern.com> MIME-version: 1.0 X-Mailer: Z-Mail (5.0.0 30July97) Content-type: text/plain; charset=us-ascii References: <20050425063521.GA17598@quark.hightek.org> <1050425163202.ZM25027@candle.brasslantern.com> <20050426030308.GA21501@quark.hightek.org> <200504261834.j3QIYHSa018951@news01.csr.com> <1050427053638.ZM28743@candle.brasslantern.com> <200504270954.j3R9sujP029445@news01.csr.com> <1050427140931.ZM29524@candle.brasslantern.com> <20050501185447.GA24296@quark.hightek.org> <200505031004.j43A47jB014589@news01.csr.com> <1050504014218.ZM18778@candle.brasslantern.com> <13894.1115198893@csr.com> Comments: In reply to Peter Stephenson "Re: localtraps" (May 4, 10:28am) X-Spam-Checker-Version: SpamAssassin 3.0.2 on a.mx.sunsite.dk X-Spam-Level: X-Spam-Status: No, score=-2.6 required=6.0 tests=AWL,BAYES_00 autolearn=ham version=3.0.2 X-Spam-Hits: -2.6 On May 4, 10:28am, Peter Stephenson wrote: } Subject: Re: localtraps } } Bart Schaefer wrote: } > It gave an error because "test -f $target" failed, because the target } > does not exist. This is a result of a change I recently committed. I take that back -- the last part about the change I committed, that is. Vincent reported the error for the 4.2.x patches branch, but my change was committed only on the head revision. } > Tell me again why we should create and test for an empty file in the } > event tht yodl doesn't exist? } } No idea. Probably the code originally tested for something completely } different, e.g. there wasn't a redirection or there was a cp, or whatever. May I suggest: Index: Doc/Makefile.in =================================================================== diff -c -r1.14 Makefile.in --- Doc/Makefile.in 18 Feb 2005 17:05:15 -0000 1.14 +++ Doc/Makefile.in 4 May 2005 14:21:14 -0000 @@ -114,11 +114,10 @@ */*) target=$@ ;; \ *) target=$(sdir)/$@ ;; \ esac; \ - case '$(YODL)' in :*) ;; *) \ + case '$(YODL)' in :*) touch $$target ;; *) \ echo $(YODL) -o $$target -I$(sdir) -w zman.yo version.yo $< ; \ $(YODL) -I$(sdir) -w zman.yo version.yo $< | sed -e '1s/\\-/-/g' -e '/^\.'\''/d' > $$target \ ;; esac; \ - test -f $$target ps: us_ps a4_ps .PHONY: ps @@ -146,17 +145,15 @@ */*) target=$@ ;; \ *) target=$(sdir)/$@ ;; \ esac; \ - case '$(YODL)' in :*) ;; *) \ + case '$(YODL)' in :*) touch $$target ;; *) \ echo $(YODL) -o $$target -I$(sdir) -DZSHALL -w zman.yo version.yo zsh.yo; \ $(YODL) -I$(sdir) -DZSHALL -w zman.yo version.yo zsh.yo | sed -e '1s/\\-/-/g' -e '/^\.'\''/d' > $$target \ ;; esac; \ - test -f $$target ../META-FAQ: META-FAQ.yo Zsh/metafaq.yo - case '$(YODL)' in :*) ;; *) \ + case '$(YODL)' in :*) touch $(sdir_top)/META-FAQ ;; *) \ $(YODL) -I$(sdir) META-FAQ.yo | sed -e '/NEXTLINE/N' -e '/DELLINE/d' -e '/^SECTHEAD$$/{N;s/^SECTHEAD.//;h;s/./-/g;H;g;}' -e 's/ *$$//' > $(sdir_top)/META-FAQ \ ;; esac - test -f $(sdir_top)/META-FAQ $(YODLDOC): version.yo