From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23753 invoked from network); 7 May 2005 18:34:44 -0000 Received: from news.dotsrc.org (HELO a.mx.sunsite.dk) (130.225.247.88) by ns1.primenet.com.au with SMTP; 7 May 2005 18:34:44 -0000 Received: (qmail 99358 invoked from network); 7 May 2005 18:34:38 -0000 Received: from sunsite.dk (130.225.247.90) by a.mx.sunsite.dk with SMTP; 7 May 2005 18:34:38 -0000 Received: (qmail 26245 invoked by alias); 7 May 2005 18:34:35 -0000 Mailing-List: contact zsh-workers-help@sunsite.dk; run by ezmlm Precedence: bulk X-No-Archive: yes X-Seq: 21236 Received: (qmail 26235 invoked from network); 7 May 2005 18:34:35 -0000 Received: from news.dotsrc.org (HELO a.mx.sunsite.dk) (130.225.247.88) by sunsite.dk with SMTP; 7 May 2005 18:34:35 -0000 Received: (qmail 99021 invoked from network); 7 May 2005 18:34:35 -0000 Received: from vms044pub.verizon.net (206.46.252.44) by a.mx.sunsite.dk with SMTP; 7 May 2005 18:34:30 -0000 Received: from candle.brasslantern.com ([4.11.1.68]) by vms044.mailsrvcs.net (Sun Java System Messaging Server 6.2 HotFix 0.04 (built Dec 24 2004)) with ESMTPA id <0IG4009CSU9GNYXB@vms044.mailsrvcs.net> for zsh-workers@sunsite.dk; Sat, 07 May 2005 13:34:29 -0500 (CDT) Received: from candle.brasslantern.com (IDENT:schaefer@localhost [127.0.0.1]) by candle.brasslantern.com (8.12.11/8.12.11) with ESMTP id j47IYSZ1003063 for ; Sat, 07 May 2005 11:34:28 -0700 Received: (from schaefer@localhost) by candle.brasslantern.com (8.12.11/8.12.11/Submit) id j47IYRqM003062 for zsh-workers@sunsite.dk; Sat, 07 May 2005 11:34:27 -0700 Date: Sat, 07 May 2005 18:34:27 +0000 From: Bart Schaefer Subject: PATCH: Another minor bug in _remote_files To: zsh-workers@sunsite.dk Message-id: <1050507183427.ZM3061@candle.brasslantern.com> MIME-version: 1.0 X-Mailer: Z-Mail (5.0.0 30July97) Content-type: text/plain; charset=us-ascii X-Spam-Checker-Version: SpamAssassin 3.0.2 on a.mx.sunsite.dk X-Spam-Level: X-Spam-Status: No, score=-2.6 required=6.0 tests=AWL,BAYES_00 autolearn=ham version=3.0.2 X-Spam-Hits: -2.6 Completions for ssh/scp give up to early, without trying all completers in the appropriate zstyle, because _remote_files always returns success even when it finds no matches. The drawback to fixing this is that ssh/scp completions may get a lot slower, because multiple remote executions of "ls" may occur in order to satisfy all the possible combinations. Index: Completion/Unix/Command/_ssh =================================================================== retrieving revision 1.14 diff -c -r1.14 _ssh --- Completion/Unix/Command/_ssh 6 Dec 2004 16:51:17 -0000 1.14 +++ Completion/Unix/Command/_ssh 7 May 2005 18:29:21 -0000 @@ -23,6 +27,7 @@ done (( ret )) || return 0 done + return ret else _message -e remote-files 'remote file' fi