From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5874 invoked from network); 6 Jun 2005 16:25:07 -0000 Received: from news.dotsrc.org (HELO a.mx.sunsite.dk) (130.225.247.88) by ns1.primenet.com.au with SMTP; 6 Jun 2005 16:25:07 -0000 Received: (qmail 9589 invoked from network); 6 Jun 2005 16:25:01 -0000 Received: from sunsite.dk (130.225.247.90) by a.mx.sunsite.dk with SMTP; 6 Jun 2005 16:25:01 -0000 Received: (qmail 4171 invoked by alias); 6 Jun 2005 16:24:58 -0000 Mailing-List: contact zsh-workers-help@sunsite.dk; run by ezmlm Precedence: bulk X-No-Archive: yes X-Seq: 21309 Received: (qmail 4152 invoked from network); 6 Jun 2005 16:24:57 -0000 Received: from news.dotsrc.org (HELO a.mx.sunsite.dk) (130.225.247.88) by sunsite.dk with SMTP; 6 Jun 2005 16:24:57 -0000 Received: (qmail 9277 invoked from network); 6 Jun 2005 16:24:57 -0000 Received: from vms048pub.verizon.net (206.46.252.48) by a.mx.sunsite.dk with SMTP; 6 Jun 2005 16:24:53 -0000 Received: from candle.brasslantern.com ([4.11.1.68]) by vms048.mailsrvcs.net (Sun Java System Messaging Server 6.2 HotFix 0.04 (built Dec 24 2004)) with ESMTPA id <0IHO00FNQ89F6NK2@vms048.mailsrvcs.net> for zsh-workers@sunsite.dk; Mon, 06 Jun 2005 11:24:52 -0500 (CDT) Received: from candle.brasslantern.com (IDENT:schaefer@localhost [127.0.0.1]) by candle.brasslantern.com (8.12.11/8.12.11) with ESMTP id j56GOobU022222 for ; Mon, 06 Jun 2005 09:24:50 -0700 Received: (from schaefer@localhost) by candle.brasslantern.com (8.12.11/8.12.11/Submit) id j56GOoh3022221 for zsh-workers@sunsite.dk; Mon, 06 Jun 2005 09:24:50 -0700 Date: Mon, 06 Jun 2005 16:24:50 +0000 From: Bart Schaefer Subject: Re: PATCH: expl not always local In-reply-to: <20050606133349.GC16824@localhost.localdomain> To: zsh-workers@sunsite.dk Message-id: <1050606162450.ZM22220@candle.brasslantern.com> MIME-version: 1.0 X-Mailer: Z-Mail (5.0.0 30July97) Content-type: text/plain; charset=us-ascii References: <20050602132519.GA10266@localhost.localdomain> <1050602152831.ZM12324@candle.brasslantern.com> <2817.1117730651@trentino.groupinfra.com> <1050602170247.ZM12815@candle.brasslantern.com> <20050606133349.GC16824@localhost.localdomain> Comments: In reply to Doug Kearns "Re: PATCH: expl not always local" (Jun 6, 11:33pm) X-Spam-Checker-Version: SpamAssassin 3.0.2 on a.mx.sunsite.dk X-Spam-Level: X-Spam-Status: No, score=-2.6 required=6.0 tests=BAYES_00 autolearn=ham version=3.0.2 X-Spam-Hits: -2.6 On Jun 6, 11:33pm, Doug Kearns wrote: } } > } Bart wrote: } > } > Careful with these. They may be expecting to be called in a context } > } > where the caller has declared expl as a local. } } I might be missing something, but isn't leaving these few exceptions } only encouraging future completion functions to rely on the incorrect } behaviour? If you're confident that other functions aren't expecting these to pass back a value in $expl, then I don't have a problem with committing the change.