Re: PATCH: displaying wide characters

[Bart Schaefer <schaefer@brasslantern.com>]

On Oct 21, 10:03am, Peter Stephenson wrote:
} Subject: Re: PATCH: displaying wide characters
}
} It looks like it, but it isn't.  I didn't change the old code here, and
} this feature is in 4.2.

Ah, so this is a newly-added test that's failing.  I missed that part.

}           If the string is longer than the  specified  truncation
}           length,  it  will  appear in full, completely replacing
}           the truncated string.
} 
} which is unambiguous, so I presume there is a bug in the old code.

Either that or an intentional change that failed to make it into the
documentation.  The prompt truncation code was completely rewritten a
while back (prior to 4.0, so *quite* a while back).

} I suspect it's too minor to worry much about and I should just fix the
} old code.  The only time I can think of where this is significant is
} if you have a string with a variable truncation length or truncation
} indicator so can't guarantee in advance this won't happen, which must
} be fairly unlikely.

Actually that's used in some of the themed prompts that are distributed
with the shell, including adam2 and (ahem) bart, so it's not as unlikely
as you might think.