zsh-workers
 help / color / mirror / code / Atom feed
From: Bart Schaefer <schaefer@brasslantern.com>
To: zsh-workers@sunsite.dk
Subject: Re: [4.2/4.3] Bug with wait and trapped signals
Date: Tue, 21 Feb 2006 04:06:29 +0000	[thread overview]
Message-ID: <1060221040629.ZM24174@candle.brasslantern.com> (raw)
In-Reply-To: <200602181731.k1IHVoxk010917@pwslaptop.csr.com>

On Feb 18,  5:31pm, Peter Stephenson wrote:
}
} I would prefer if there was someone more proficient in the dark art of
} signals to look at this.

I don't know whether I qualify or not, but it looks mostly OK to me.  I
may even be able to answer this old question:

} +#ifdef POSIX_SIGNALS
} +	sigdelset(set, SIGHUP);  /* still don't know why we add this? */
} +#endif

The reason for this is so that the shell exits properly if the
terminal is disconnected (window closed, whatever) during the wait.

} I also inserted an "else" which seemed to want to be present where it's
} marked "HERE" (another CSR habit).

I think the intention there is to reap any other jobs that exited
while we were waiting for the specified job, because we won't get
the normal SIGCHLD signals for those.  However, I'm note entirely
sure that was necessary or that it accomplished what it meant to.


      parent reply	other threads:[~2006-02-21  4:06 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-02-17 14:28 Vincent Lefevre
2006-02-17 18:08 ` Dan Nelson
2006-02-18  0:50   ` Vincent Lefevre
2006-02-18 17:31 ` Peter Stephenson
2006-02-18 17:36   ` Peter Stephenson
2006-02-21  4:06   ` Bart Schaefer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1060221040629.ZM24174@candle.brasslantern.com \
    --to=schaefer@brasslantern.com \
    --cc=zsh-workers@sunsite.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).