zsh-workers
 help / color / mirror / Atom feed
* [PATCH] Fix [:IDENT:] vs posixidentifiers
@ 2020-12-17 15:08 Stephane Chazelas
  2021-02-07 15:50 ` Stephane Chazelas
  0 siblings, 1 reply; 6+ messages in thread
From: Stephane Chazelas @ 2020-12-17 15:08 UTC (permalink / raw)
  To: Zsh hackers list

$ zsh -c '[[ é = [[:IDENT:]] ]]' || echo no
no
$ zsh -o posixidentifiers -c '[[ é = [[:IDENT:]] ]]' && echo yes
yes

That should be the other way round.


From: Stephane Chazelas <stephane@chazelas.org>
Date: Thu, 17 Dec 2020 14:49:50 +0000
Subject: [PATCH] Fix [:IDENT:] vs posixidentifiers

wcsitype(c, IIDENT) should return false for non-ASCII characters
when the POSIX_IDENTIFIERS option is on, not the other way round.
---
 Src/utils.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Src/utils.c b/Src/utils.c
index 5151b89a8..2a8d677a7 100644
--- a/Src/utils.c
+++ b/Src/utils.c
@@ -4327,7 +4327,7 @@ wcsitype(wchar_t c, int itype)
     } else {
 	switch (itype) {
 	case IIDENT:
-	    if (!isset(POSIXIDENTIFIERS))
+	    if (isset(POSIXIDENTIFIERS))
 		return 0;
 	    return iswalnum(c);
 
-- 
2.29.2


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] Fix [:IDENT:] vs posixidentifiers
  2020-12-17 15:08 [PATCH] Fix [:IDENT:] vs posixidentifiers Stephane Chazelas
@ 2021-02-07 15:50 ` Stephane Chazelas
  2021-02-07 20:24   ` Bart Schaefer
  0 siblings, 1 reply; 6+ messages in thread
From: Stephane Chazelas @ 2021-02-07 15:50 UTC (permalink / raw)
  To: Zsh hackers list

Ping. Anybody objecting to this?

2020-12-17 15:08:44 +0000, Stephane Chazelas:
> $ zsh -c '[[ é = [[:IDENT:]] ]]' || echo no
> no
> $ zsh -o posixidentifiers -c '[[ é = [[:IDENT:]] ]]' && echo yes
> yes
> 
> That should be the other way round.
> 
> 
> From: Stephane Chazelas <stephane@chazelas.org>
> Date: Thu, 17 Dec 2020 14:49:50 +0000
> Subject: [PATCH] Fix [:IDENT:] vs posixidentifiers
> 
> wcsitype(c, IIDENT) should return false for non-ASCII characters
> when the POSIX_IDENTIFIERS option is on, not the other way round.
> ---
>  Src/utils.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Src/utils.c b/Src/utils.c
> index 5151b89a8..2a8d677a7 100644
> --- a/Src/utils.c
> +++ b/Src/utils.c
> @@ -4327,7 +4327,7 @@ wcsitype(wchar_t c, int itype)
>      } else {
>  	switch (itype) {
>  	case IIDENT:
> -	    if (!isset(POSIXIDENTIFIERS))
> +	    if (isset(POSIXIDENTIFIERS))
>  		return 0;
>  	    return iswalnum(c);
>  
> -- 
> 2.29.2
> 


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] Fix [:IDENT:] vs posixidentifiers
  2021-02-07 15:50 ` Stephane Chazelas
@ 2021-02-07 20:24   ` Bart Schaefer
  2021-02-08  5:53     ` Daniel Shahaf
  0 siblings, 1 reply; 6+ messages in thread
From: Bart Schaefer @ 2021-02-07 20:24 UTC (permalink / raw)
  To: Zsh hackers list

On Sun, Feb 7, 2021 at 7:50 AM Stephane Chazelas <stephane@chazelas.org> wrote:
>
> Ping. Anybody objecting to this?

Not I.  We're behind on merging several patches, I think.


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] Fix [:IDENT:] vs posixidentifiers
  2021-02-07 20:24   ` Bart Schaefer
@ 2021-02-08  5:53     ` Daniel Shahaf
  2021-02-08 20:51       ` Bart Schaefer
  0 siblings, 1 reply; 6+ messages in thread
From: Daniel Shahaf @ 2021-02-08  5:53 UTC (permalink / raw)
  To: zsh-workers

Bart Schaefer wrote on Sun, Feb 07, 2021 at 12:24:26 -0800:
> On Sun, Feb 7, 2021 at 7:50 AM Stephane Chazelas <stephane@chazelas.org> wrote:
> >
> > Ping. Anybody objecting to this?
> 
> Not I.  We're behind on merging several patches, I think.

Do we need a patch manager?

(See, for instance,
https://subversion.apache.org/docs/community-guide/roles#patch-manager;
tl;dr: someone who watches PATCH threads and pings them if they peter out
unresolved — neither accepted nor rejected.)


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] Fix [:IDENT:] vs posixidentifiers
  2021-02-08  5:53     ` Daniel Shahaf
@ 2021-02-08 20:51       ` Bart Schaefer
  2021-02-09  9:11         ` Peter Stephenson
  0 siblings, 1 reply; 6+ messages in thread
From: Bart Schaefer @ 2021-02-08 20:51 UTC (permalink / raw)
  To: Daniel Shahaf; +Cc: zsh-workers

On Sun, Feb 7, 2021 at 9:54 PM Daniel Shahaf <d.s@daniel.shahaf.name> wrote:
>
> tl;dr: someone who watches PATCH threads and pings them if they peter out
> unresolved — neither accepted nor rejected.)

That would be nice.  Peter/Oliver/I used to sort of tag-team that, but
we have all run out of time/attention for it.


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] Fix [:IDENT:] vs posixidentifiers
  2021-02-08 20:51       ` Bart Schaefer
@ 2021-02-09  9:11         ` Peter Stephenson
  0 siblings, 0 replies; 6+ messages in thread
From: Peter Stephenson @ 2021-02-09  9:11 UTC (permalink / raw)
  To: zsh-workers

> On 08 February 2021 at 20:51 Bart Schaefer <schaefer@brasslantern.com> wrote:
> On Sun, Feb 7, 2021 at 9:54 PM Daniel Shahaf <d.s@daniel.shahaf.name> wrote:
> >
> > tl;dr: someone who watches PATCH threads and pings them if they peter out
> > unresolved — neither accepted nor rejected.)
> 
> That would be nice.  Peter/Oliver/I used to sort of tag-team that, but
> we have all run out of time/attention for it.

Yes, I think attention is mostly the thing in my case.  I do have the odd
5 minutes every now and then to apply and push patches if my brain has been
sufficiently lit up.

pws


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2021-02-09  9:11 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-17 15:08 [PATCH] Fix [:IDENT:] vs posixidentifiers Stephane Chazelas
2021-02-07 15:50 ` Stephane Chazelas
2021-02-07 20:24   ` Bart Schaefer
2021-02-08  5:53     ` Daniel Shahaf
2021-02-08 20:51       ` Bart Schaefer
2021-02-09  9:11         ` Peter Stephenson

zsh-workers

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.vuxu.org/zsh-workers

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V1 zsh-workers zsh-workers/ http://inbox.vuxu.org/zsh-workers \
		zsh-workers@zsh.org
	public-inbox-index zsh-workers

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.vuxu.org/vuxu.archive.zsh.workers


code repositories for the project(s) associated with this inbox:

	https://git.vuxu.org/mirror/zsh/

AGPL code for this site: git clone https://public-inbox.org/public-inbox.git