From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FROM,HTML_MESSAGE,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 21117 invoked from network); 30 Nov 2023 00:15:35 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 30 Nov 2023 00:15:35 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20210803; t=1701303336; b=LozV/kYq9avAe50oOb8flU3/rEAbOO9qclOLjTfEdPyluF5Ue1Ahfsjh7mPZ55PL4RQbbPTsUD uZksBBgK/72etfF9JmEhm5TSOGXa0j//CDYF7Jjq+MUfLXiSV5rERkJUT1KncQq1T1j3Z95pr0 sItyvIGnc9CwNel2RoOkHiu8tum0sMqfU8sYbyCRBiHN2iwqz2aaKcs8P4oz6Ue/cqj86F7n0R ao+MlEvF8d1+69xaqg3TVDqwOGQQ+gOKkAU/ihn05jdFpqFLEaeS9kzKX7IhvfIqEBtPYSyv5w KVr3svjO4i4Y68nFqw+rpyTk66GC3PAVXpeFoLiajjR7BQ==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (sonic312-25.consmr.mail.ne1.yahoo.com) smtp.remote-ip=66.163.191.206; dkim=pass header.d=yahoo.com header.s=s2048 header.a=rsa-sha256; dmarc=pass header.from=yahoo.com; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20210803; t=1701303336; bh=tm3Dv7hjQpmmMbsQfeDIfSHtBTdYqB6cfMSxG49gm6A=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:Content-Type:MIME-Version:Subject:References:In-Reply-To: Message-ID:Cc:To:From:Date:DKIM-Signature:DKIM-Signature; b=noNdo11wytTiUNlxbf71pbmkHdNRPcHfSSDfXawCaGbQ5oIPTRGEQ8hxEI+qmaab78aGNs+Duy 7yxAKcmFRO4V+XGOCBvsHsYHD6iNjdnnBLDCMLioNXDGLkjOtp7BMjwepynGGxXlX4K8gD450d ZPq7SvpVvQSmchsxP1q0QpHc6m6Ecos2NjyIjP9yw4ptbxuM8pIuTnsNZWwehcL3EGSPv/zEND VQhRGDupaP4lhs2kScpt8Kl5lbi888s0zIZi4ZU4U90gSUETRy0+lKI+0y+/xGSjZHnjyh3URg +RScAlJedMiSbtjjwWSKSa1052bfQ3XGU8q8QHMeG5rzwg==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20210803; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:Content-Type:MIME-Version:Subject: References:In-Reply-To:Message-ID:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=Kb2Gt/lQKvq3BKJe26FG/d1cEC5DsMFv8fGEqofp0Xc=; b=f9rGQSzZ/KuLRndLPSGW9CrMnN HDdChHDTLdE3TW/zU+hCBXb/rBC1es2KFUpySeHfKLcMKbCX1nlZagkHCSBOpWI68KQ0ww9/znOfr QmsdVtz6YPwnCfaRBF9nrBz4QR/sdVbMdo7hJyGcGLfC0RsybeGZEPcVJJPLFzD7Cj4Mi1zA4HDAX r+wCthmpOFSMaMiXB05i3/JeQAUJgX8sDbij2QeZzakwQLHLC5kI0fIz/U50oTgZkvosDnkB85u7T JdUbUflJt+9xbntF49SqIV0H6pFqIb88QhOhO2l4S/rQ+JKzUKqQC8CNamBvncslZclPbDE1uojwY PQDsNDDw==; Received: by zero.zsh.org with local id 1r8UiN-000LmW-3U; Thu, 30 Nov 2023 00:15:35 +0000 Authentication-Results: zsh.org; iprev=pass (sonic312-25.consmr.mail.ne1.yahoo.com) smtp.remote-ip=66.163.191.206; dkim=pass header.d=yahoo.com header.s=s2048 header.a=rsa-sha256; dmarc=pass header.from=yahoo.com; arc=none Received: from sonic312-25.consmr.mail.ne1.yahoo.com ([66.163.191.206]:39311) by zero.zsh.org with esmtps (TLS1.3:TLS_AES_128_GCM_SHA256:128) id 1r8Ui5-000LTB-2W; Thu, 30 Nov 2023 00:15:19 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1701303315; bh=Kb2Gt/lQKvq3BKJe26FG/d1cEC5DsMFv8fGEqofp0Xc=; h=Date:From:To:Cc:In-Reply-To:References:Subject:From:Subject:Reply-To; b=SNXCUe0yjeu4nL3SHJz5nX1jNlWkNObKatpQ/JzswGWZx3MorkMQseDiMg7KEN2d+Kpi+XHlX3KuhYhbggufWwAXZHAViqQv7oqLya6YnfCjxFVzcW1txjs3Uast992JjYqMMGk7+jbr/FeqTbLhtIyiBVo812e63HzZ0OlrCA4pBiDIJnV9hJ4PhzZpy16cRnzXjGdqnedI3NOGotI+KLpvovi8E5EobL0+HpJ/kXhSY19AZzU4pauAVwSGl2SLjD1raZvn5OZlii6XEza9ozcKY7T1ECb2AQsH/nfTAzH40r01Fu34Ljw6yu+xgs9NH9cubbu/qOj7JhG9uhLm2Q== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1701303315; bh=zZP7jPnNNT1s+OXeRIg99bjr4xhH78oH8HoJJlyz8ek=; h=X-Sonic-MF:Date:From:To:Subject:From:Subject; b=FChG9fhiUEAr3+OsUgdOp09x5Hh8QP4teJEZLkaE/xrSB6hynshb851eBXoQK3BpVUZ42zOvB3mPfeTI70p49LcpMojfp1Jf2p7cpb3f7V44zCo3H0q/OwO5oEbWBarE7LPv5nEUWLHvyDpGEeQSwYF8TkULnHHLnqzinmTlvv0KYOzXaQ412oqZ5OPR6R7PQQHzSojMmk1m09jIgGlxlDjnkVVLnbFqVza8Ogo+vXf7JuIDvjKJ4/w1NfYlC6DofIqFDs/INb+Q9A3WU2kZTXRnlIjUNX8YtFi9Zit0EEwROhVFULnlG/rQzrP/OFbvjg3c73gTKFA5M8I23Higkg== X-YMail-OSG: KFTskdMVM1kzPWzLIe67Wx88t99HqUwhJboyBZCwr4XBLN.2Mw_NL5GpvpCzkEB 8mCmxakAMFkX833SifqA50N43w4CFPXdmRuE7EmNSm4lCQvJSk81PqsQPqDakfT09YZyc1uTxeW. Mu.g5v1p5_64w.YnJfMytdOMVdVggsT7omNlGGbbsiKjpyUsHYENlK9frM2g3L7_CLMe.HO79oiu W4GanJxCeDpVL.DboSQ3Z5H4NI6Ipa55YQyxLf8Au0_hS9OLEvXw6ExvShmnJgryJCd_4_3unEYq eh2L76BYHIl3ZMfODPuXK2lPdCq.SxP89tSQpF3GHhQxBEoilCVtUUcvwmHtSdBIxVgU00YlXIFh .O7aBp6e1JSzIWnYHQUeRN6mHdBFpIZPyz96Bui35gCXJlm_oQvpqOPECA76zR96bna.g1Qzmea1 cD0.lqm4gKzgyzkwJFj7jZQ.LoTOXmOvdmglr4xiF9ya40mVljd5eSkJXbh4GfzAeWuIrKxJsGb9 3aPe8xZLkJ7EMTf3AoJlmZRTa20cdD8tzfjwBvZmAD4MX0JkxD6pFQHBbmUZpdcQgWkOCFTewqUH b9v8xbL.VUMbALjs15WPSEhBImUamIwO1W6ZEJe0AwaRsthdx7_G7fcJVZIPcmYRq2.dvVLrVsm5 mWPG5djsn9bY7BXTVyUzpiJpdsePt350wHOL137Lr1p2zL3DPposyTIHajbqrIZelHEaDxQDtdYd 1SkMHcVkgnh82UkGDng0BG2B1QGiyJrf4XH.3VukM8MgLihCAc13xuVNVmBOgkHT9fxb.k7H0waj AiSb8rZnchW3JhSLvpR7yFvMZ3hXzOm8MWiAOP9mAuqst2LSuD75jp1cOF.tXZUnYunXURPwxFxi gfJ85KwQB40nSZ_s4e5FWBHhebvq6x59Tq2lDxhFu0UpBhul.kYb0TF.Oa.9Onu2K8gNdJpygaO8 bo4nEGQs5TTwTVWdev7rUgbzkYfm3xKeiU9Scm605Z.Cy44EOPHOfCgD756cy4gwFAHdM8ubHaCW rIXNZQFnoPJBpD5ibAur6g2irAykbxeHrj3m_YxJpAz5BBef8zd8WKg1QLebeIyRLwsnhkeSQzIz KsGe8rg7N0C1uasIzUxF1Uw1LrGucs7bHimBJyXxjyU24C2v.f8C1lndRKt3h0.mB40eAEZAz8TK e9L3jyqD4AaWRg5vdpkeghCOmzArRzESfY0pQr8Ge1OMvcfCySkw_djuSr34Ka2Vr1N2C2e8.t.F ezWLKO74p5xtEJzaRyH94swbfHozp_5xucRA0Su2v1RLGCYbARtdcEIB7ungf3O3u4cB7cR_66t2 o6sy9hBAxZs.mNjlglQagC4sfwMWIV5ryjEyiLmuV97w5lLYht3JpPbtwnTSbZAvQ.9.RfJynY_w rWKGlu9RIdh3RQEqcIMWwPO1axRO81IhaOH0iYd5266ApWLHDHyLk7N9P8psqgqJ5jQbY3digBP6 GdZva1A5HcvlyGEKiN21V4dFI75_gVmKNHsKCVt6JmfiaJJw.aQYRCR4JxT7Z_RpW_t1WCj.xh.m 17IHuiOrme0WYCwfKjLYamkjsUZ40yfPR1A41UZGnt2hzJGIK0449hK3qsWKIZorBfZ7evKJfY4F vQ27ONILCEUrJC_GnFjIIHzIBNt7hee68nr9NApshU7taJv6zvr5nUC_Mzoz6js9thbMT19gUtzU uIuwm.e1i64FF94F3sBpFnWFdwQxuQonYUJzMhMrZksWW23aq._Za67Q.lSTglVFoguuShJ3uYnB t6..LEJm7QCF_ysLrGn_soXs7nQM9_LgLQKtaNfDiBiYfMQuWZEsf0LU2dFQA968Ib3OySv00M2W l79xX7SpqapacTyIh_x0_brc0T7hHEVBdr1me0aZVZJd7WhWiT1yRvAK1dleU1n_LeYsX_y8w5zp 1GftlB.Wde6A4KSBsCgFQ98T0lEqMBy8xTsrIi9WULshSWPHker6788nCxZrnNXQxzdcbvcRgGBg t_hE9HgBzzOdW.15ql.OBjdmqgr8UWIFXF3RmiQGM_ZFvMS0TNRZkPToupKZKTNUPm33hQEIbgzU Jsjuk1OhVdne72URTj6j6VlchezeBVsGUXyD9oPn_GQCFpjV6s2H2j7XI.Zi2AVlIwrvwEUknO9i bRAFtHzjeObrCabJ3rI5NfyFh9aOK19S49F3HjM.QO9HqLJi.hRfWXVILyRolIk3Sls8AG.fCKr4 NA8m.Xggb9_XtxgM9oV.sbjnYjEkIXw-- X-Sonic-MF: X-Sonic-ID: 94cb7a16-efc8-4a1a-a4e0-6a240220f0c3 Received: from sonic.gate.mail.ne1.yahoo.com by sonic312.consmr.mail.ne1.yahoo.com with HTTP; Thu, 30 Nov 2023 00:15:15 +0000 Date: Thu, 30 Nov 2023 00:15:10 +0000 (UTC) From: German Riano To: Mikael Magnusson , Bart Schaefer Cc: "zsh-workers@zsh.org" Message-ID: <1085378061.9900970.1701303310889@mail.yahoo.com> In-Reply-To: References: <207461559.9336309.1701221332233.ref@mail.yahoo.com> <207461559.9336309.1701221332233@mail.yahoo.com> Subject: Re: PATCH: Improve quote handling in _ant completion MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="----=_Part_9900969_199303180.1701303310888" X-Mailer: WebService/1.1.21896 YMailNorrin X-Seq: 52339 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: , List-Subscribe: , List-Unsubscribe: , List-Post: List-Owner: List-Archive: ------=_Part_9900969_199303180.1701303310888 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable I checked and this works. Even just using 'print -qn' works. Questions: 1. Is "${(qq):-$ln} equivalent to "${(qq)ln} ?2. Does the read command need= s '-r' ?3. Does using eval creates the risk of arbitrary execution of code? On Wednesday, November 29, 2023 at 03:45:08 PM PST, Bart Schaefer wrote: =20 =20 On Wed, Nov 29, 2023 at 11:56=E2=80=AFAM Mikael Magnusson wrote: > > On 11/29/23, Bart Schaefer wrote: > > -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = print -n "'${default_target}:(Default target) ' " > > +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = print -rn -- "${(qq):-${default_target}:(Default target) } " A similar change needs to be applied a bit later, I think: =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (*) =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 # Ret= urn target and description -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 prin= t -n "'$ln' " +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 prin= t -rn -- "${(qq):-$ln} " =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ;; If this seems OK I'll prepare a proper patch. > >> Also I am proposing to shield 'find_targets' with '(( > >> $#functions[find_targets] )) ||' so that users can easily override the > >> function. > > It should probably also be renamed to _ant_find_targets or something Agreed. =20 ------=_Part_9900969_199303180.1701303310888 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
<= br>
I checked and this works. E= ven just using 'print -qn' works.

Questions:
1. Is "${(qq):-$ln} equivalent to "${(= qq)ln} ?
<= span>2. Does the read command needs '-r' ?
3. Does using eval creates the risk of arbitrary e= xecution of code?


=20
=20
On Wednesday, November 29, 2023 at 03:45:08 PM PST, Bar= t Schaefer <schaefer@brasslantern.com> wrote:


On Wed, Nov 29, 2023 at 11:56=E2=80= =AFAM Mikael Magnusson <mikachu@gmail.com> wrote:
>
> On 11/29/23, Bart Schaefer <<= a shape=3D"rect" href=3D"mailto:schaefer@brasslantern.com" rel=3D"nofollow"= target=3D"_blank">schaefer@brasslantern.com> wrote:
> > -                 = ;   print -n "'${default_target}:(Default target) ' "
> > +                 =   print -rn -- "${(qq):-${default_target}:(Default target) } "

A similar change needs to be applied a bit l= ater, I think:

      &n= bsp;         (*)
     = ;               # Return target and des= cription
-             = ;       print -n "'$ln' "
+    &= nbsp;               print -rn -- "${(qq)= :-$ln} "
             =   ;;

If this seems OK I'll prep= are a proper patch.


> >> Also I am = proposing to shield 'find_targets' with '((
> >>= $#functions[find_targets] )) ||' so that users can easily override the
> >> function.
>
> It should probably also be renamed to _ant_find_targets or someth= ing


Agreed.

------=_Part_9900969_199303180.1701303310888--