Re: Bug#607603: zsh: Completion of fuser command does not detect psmisc version

Re: Bug#607603: zsh: Completion of fuser command does not detect psmisc version

[Clint Adams]

On Mon, Dec 20, 2010 at 12:04:44AM -0500, gi1242+debianbugs@gmail.com wrote:
> The completion function for fuser tries to determine if fuser is
> provided by PSmisc, or other the (less functional) generic Unix version.
> It decides by checking the output of "fuser -V" for psmisc. However it
> does not use case insensitive matching, so the test fails on my system
> (even though my fuser is provided by psmisc).
> 
> Changing line 6 in
> 
>     /usr/share/zsh/functions/Completion/Unix/_fuser
> 
> from
> 
>     if _pick_variant -c $words[1] psmisc=psmisc unix -V; then
> 
> to
> 
>     if _pick_variant -c $words[1] psmisc='(#i)psmisc' unix -V; then
> 
> fixes the problem.


Thanks.

Index: Completion/Unix/Command/_fuser
===================================================================
RCS file: /cvsroot/zsh/zsh/Completion/Unix/Command/_fuser,v
retrieving revision 1.4
diff -u -r1.4 _fuser
--- Completion/Unix/Command/_fuser	1 Apr 2005 19:49:40 -0000	1.4
+++ Completion/Unix/Command/_fuser	25 Dec 2010 15:16:51 -0000
@@ -3,7 +3,7 @@
 local -a args arg1
 typeset -A opt_args
 
-if _pick_variant -c $words[1] psmisc=psmisc unix -V; then
+if _pick_variant -c $words[1] psmisc='#(i)psmisc' unix -V; then
 
   (( $+functions[_fuser_services] )) ||
   _fuser_services() {

Re: Bug#607603: zsh: Completion of fuser command does not detect psmisc version

[gi1242+debianbugs]

Hi Clint,

Looks like there's a typo in your patch below:

> -if _pick_variant -c $words[1] psmisc=psmisc unix -V; then
> +if _pick_variant -c $words[1] psmisc='#(i)psmisc' unix -V; then

Should be '(#i)...' not '#(i)...' right?

Thanks,

GI

PS: I started using zsh 2 weeks ago. It is *AWESOME*, thanks a TON. I'm
    migrating my custom completions over from tcsh, and have a few new
    zsh completions, and corrections to old completions to contribute.
    What is the best way to post them? Debian bugzilla, or the mailing
    list?

-- 
The short fortuneteller who escaped from prison was a small medium at
large.

Re: Bug#607603: zsh: Completion of fuser command does not detect psmisc version

[Bart Schaefer]

On Jan 2, 11:17am, gi1242+debianbugs@gmail.com wrote:
}
} PS: I started using zsh 2 weeks ago. It is *AWESOME*, thanks a TON. I'm
}     migrating my custom completions over from tcsh, and have a few new
}     zsh completions, and corrections to old completions to contribute.
}     What is the best way to post them? Debian bugzilla, or the mailing
}     list?

The zsh project isn't associated with Debian except via Clint, so one
of the zsh mailing lists is definitely the way to go.

Re: Bug#607603: zsh: Completion of fuser command does not detect psmisc version

[Clint Adams]

On Sun, Jan 02, 2011 at 11:17:06AM -0500, gi1242+debianbugs@gmail.com wrote:
> Should be '(#i)...' not '#(i)...' right?

Ugh, yes, sorry.  Fixed in CVS.

> PS: I started using zsh 2 weeks ago. It is *AWESOME*, thanks a TON. I'm
>     migrating my custom completions over from tcsh, and have a few new
>     zsh completions, and corrections to old completions to contribute.
>     What is the best way to post them? Debian bugzilla, or the mailing
>     list?

Given how negligent I've been lately, I would suggest zsh-workers.