From: Bart Schaefer <schaefer@brasslantern.com>
To: Julien Nicoulaud <julien.nicoulaud@gmail.com>
Cc: cheer_xiao <xiaqqaix@gmail.com>, zsh-workers@zsh.org
Subject: Re: Slow completion when using aptitude
Date: Sun, 30 Jan 2011 16:02:20 -0800 [thread overview]
Message-ID: <110130160220.ZM15815@torch.brasslantern.com> (raw)
In-Reply-To: <AANLkTi=PxzNVGxac5v64UZ4Sa_JwFXAdhxnxrpx_3gtw@mail.gmail.com>
On Jan 30, 11:51am, Julien Nicoulaud wrote:
}
} By the way, this issue was already known:
} http://www.zsh.org/mla/workers/2008/msg00930.html
So ...
_deb_packages_update_avail uses the cache to populate an array variable
of the same name.
As does _deb_packages_update_installed.
Then _deb_packages_update_uninstalled constructs a massive glob pattern
from the results of the latter, and applies it as a filter against the
former, to set a variable _deb_packages_update_uninstalled.
Thereafter the value of _deb_packages_update_uninstalled is used rather
than go through that filter again, so it *is* caching. The disk cache
isn't used by _deb*_uninstalled because the files are all on the disk
already from the other two functions.
All the time is being spent building that glob pattern, and filtering.
So try using this instead:
_deb_packages_update_uninstalled () {
_deb_packages_update_avail
_deb_packages_update_installed
if (( ! $+_deb_packages_cache_uninstalled )); then
local avail
for avail in $_deb_packages_cache_avail
do
(( ${+_deb_packages_cache_installed[(r)$avail]} )) && continue
_deb_packages_cache_uninstalledr+=( $avail )
done
fi
cachevar=_deb_packages_cache_uninstalled
}
Sometimes the most zsh-ish way to do something isn't the most efficient
way to do it. It may even be still faster to replace the "for" loop
with:
_dep_packages_cache_uninstalled=(
$( print -l $_deb_packages_cache_avail |
fgrep -vf =(print -l $_deb_packages_cache_installed) )
)
next prev parent reply other threads:[~2011-01-31 0:02 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-17 9:51 cheer_xiao
2011-01-19 12:33 ` Richard Hartmann
2011-01-26 5:11 ` cheer_xiao
2011-01-26 7:51 ` Julien Nicoulaud
2011-01-26 8:35 ` Frank Terbeck
2011-01-26 14:21 ` cheer_xiao
2011-01-26 14:55 ` Frank Terbeck
2011-01-26 17:05 ` Bart Schaefer
2011-01-26 17:29 ` Bart Schaefer
2011-01-30 2:49 ` cheer_xiao
2011-01-30 5:16 ` Bart Schaefer
2011-01-30 5:53 ` cheer_xiao
2011-01-30 7:15 ` Bart Schaefer
2011-01-30 10:40 ` Julien Nicoulaud
2011-01-30 10:51 ` Julien Nicoulaud
2011-01-30 11:18 ` cheer_xiao
2011-01-31 0:02 ` Bart Schaefer [this message]
2011-02-03 10:21 ` cheer_xiao
2011-02-03 14:56 ` Bart Schaefer
2011-02-04 3:24 ` cheer_xiao
[not found] ` <AANLkTinfzf6gM5Z83_+iQqkc+QVzGGKa3yqbPTa+Wm3A@mail.gmail.com>
[not found] ` <110203193315.ZM22047@torch.brasslantern.com>
2011-02-04 3:44 ` cheer_xiao
2011-02-04 3:48 ` cheer_xiao
2011-02-04 4:29 ` Bart Schaefer
2011-02-04 5:46 ` cheer_xiao
2011-02-04 15:04 ` Bart Schaefer
2011-02-05 9:13 ` cheer_xiao
[not found] ` <AANLkTinftiPPV-TtNU5DQ1+TV6Tb5P6AprBsRGdjoamB@mail.gmail.com>
2011-02-05 9:21 ` cheer_xiao
2011-02-05 9:30 ` cheer_xiao
2011-02-05 17:12 ` gi1242+zsh
2011-02-05 17:48 ` Bart Schaefer
2011-02-05 18:40 ` gi1242+zsh
2011-02-05 17:46 ` Bart Schaefer
2011-02-03 10:23 ` cheer_xiao
2011-02-03 14:51 ` Bart Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=110130160220.ZM15815@torch.brasslantern.com \
--to=schaefer@brasslantern.com \
--cc=julien.nicoulaud@gmail.com \
--cc=xiaqqaix@gmail.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).