zsh-workers
 help / color / mirror / code / Atom feed
From: Bart Schaefer <schaefer@brasslantern.com>
To: <zsh-workers@zsh.org>
Subject: Re: build on os x 10.6.7, xcode 3.2.6
Date: Wed, 13 Apr 2011 12:56:42 -0700	[thread overview]
Message-ID: <110413125644.ZM18368@torch.brasslantern.com> (raw)
In-Reply-To: <20110413172646.2e406efd@pwslap01u.europe.root.pri>

On Apr 13,  5:26pm, Peter Stephenson wrote:
}
} Changing random source code options often has side effects.

I thought that change looked a bit questionable.  There aren't
very many of these kinds of preprocessor directives that it's
appropriate to define unconditionally, and I don't see any
reason to remove the #if / _GNU_SOURCE definition, independent
of defining _POSIX_C_SOURCE.

} --- zsh-4.3.11/Src/system.h     2010-02-22 11:12:31.000000000 +0100
} +++ zsh/Src/system.h    2011-04-12 14:20:37.106000061 +0200
} @@ -37,13 +37,12 @@
}  #endif
}  #endif
} 
} -#if defined(__linux) || defined(__GNU__) || defined(__GLIBC__)
}  /*
}   * Turn on numerous extensions.
}   * This is in order to get the functions for manipulating /dev/ptmx.
}   */
}  #define _GNU_SOURCE 1
} -#endif
} +#define _POSIX_C_SOURCE 200809L

-- 


  parent reply	other threads:[~2011-04-13 19:57 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-12 13:09 [PATCH v2] define _GNU_SOURCE Valentin Ochs
2011-04-13 16:10 ` build on os x 10.6.7, xcode 3.2.6 S. Cowles
2011-04-13 16:26   ` Peter Stephenson
2011-04-13 19:32     ` S. Cowles
2011-04-13 19:56     ` Bart Schaefer [this message]
2011-04-14  8:35 ` [PATCH v2] define _GNU_SOURCE Peter Stephenson
2011-04-14  9:03   ` Peter Stephenson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=110413125644.ZM18368@torch.brasslantern.com \
    --to=schaefer@brasslantern.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).