From: Bart Schaefer <schaefer@brasslantern.com>
To: zsh-workers@zsh.org
Subject: Re: completion on brace + 4 characters doesn't work
Date: Thu, 28 Apr 2011 20:56:57 -0700 [thread overview]
Message-ID: <110428205657.ZM12615@torch.brasslantern.com> (raw)
In-Reply-To: <20110429013438.GC21935@prunille.vinc17.org>
On Apr 29, 3:34am, Vincent Lefevre wrote:
} Subject: Re: completion on brace + 4 characters doesn't work
}
} With "echo ./{abcd", valgrind complains:
}
} ==13848== Source and destination overlap in strcpy(0x4027532, 0x4027533)
} ==13848== at 0x4C25918: strcpy (mc_replace_strmem.c:311)
} ==13848== by 0xD09D92C: get_comp_string (zle_tricky.c:2016)
That's this line:
2016 strcpy(dbeg, dbeg + len);
The code there apparently assumes a naive implementation of strcpy()
that goes left-to-right incrementing the source and destination
pointers in lock step. There are instances of this assumption all
over the place in get_comp_string(). It would not surprise me to
find this assumption made elsewhere in the zsh sources.
Out of curiosity, does the behavior change if you crank down the
degree of optimization (or up the of debugging) in the compiler flags
when building?
Looking at the patch below, I'm puzzled by the *dbeg = '{' assignments
-- they're to restore the string after a '\0' was plugged into it
temporarily, but isn't *dbeg immediately clobbered by whatever is
at *(dbeg+len) ? Why bother restoring it? I suppose len == 0 may
be possible ...
Index: Src/Zle/zle_tricky.c
===================================================================
RCS file: /extra/cvsroot/zsh/zsh-4.0/Src/Zle/zle_tricky.c,v
retrieving revision 1.30
diff -c -r1.30 zle_tricky.c
--- zle_tricky.c 21 Dec 2010 16:41:16 -0000 1.30
+++ zle_tricky.c 29 Apr 2011 03:45:13 -0000
@@ -1899,7 +1899,7 @@
*dbeg = '{';
i -= len;
boffs -= len;
- strcpy(dbeg, dbeg + len);
+ memmove(dbeg, dbeg + len, 1+strlen(dbeg+len));
dp -= len;
}
bbeg = lastp = p;
@@ -1948,7 +1948,7 @@
*dbeg = '{';
i -= len;
boffs -= len;
- strcpy(dbeg, dbeg + len);
+ memmove(dbeg, dbeg + len, 1+strlen(dbeg+len));
dp -= len;
}
bbeg = NULL;
@@ -2013,7 +2013,7 @@
new->qpos = strlen(quotename(predup, NULL));
*dbeg = '{';
boffs -= len;
- strcpy(dbeg, dbeg + len);
+ memmove(dbeg, dbeg + len, 1+strlen(dbeg+len));
}
if (brend) {
Brinfo bp, prev = NULL;
@@ -2026,7 +2026,7 @@
l = bp->qpos;
bp->pos = strlen(predup + p + l);
bp->qpos = strlen(quotename(predup + p + l, NULL));
- strcpy(predup + p, predup + p + l);
+ memmove(predup + p, predup + p + l, 1+bp->pos);
}
}
if (hascom) {
next prev parent reply other threads:[~2011-04-29 3:57 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-28 11:11 Vincent Lefevre
2011-04-28 15:12 ` Bart Schaefer
2011-04-28 22:27 ` Vincent Lefevre
2011-04-29 0:31 ` Vincent Lefevre
2011-04-29 0:59 ` Vincent Lefevre
2011-04-29 1:34 ` Vincent Lefevre
2011-04-29 3:56 ` Bart Schaefer [this message]
2011-04-29 8:44 ` Vincent Lefevre
2011-04-29 11:15 ` Vincent Lefevre
2011-05-04 9:33 ` Vincent Lefevre
2011-04-29 14:20 ` Bart Schaefer
2011-05-02 8:08 ` Vincent Lefevre
2011-05-02 8:34 ` Vincent Lefevre
2011-05-02 11:54 ` Peter Stephenson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=110428205657.ZM12615@torch.brasslantern.com \
--to=schaefer@brasslantern.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).