From: Bart Schaefer <schaefer@brasslantern.com>
To: zsh-workers <zsh-workers@zsh.org>
Subject: Re: PATCH: Make _xset complete more helpfully
Date: Thu, 12 May 2011 10:22:12 -0700 [thread overview]
Message-ID: <110512102212.ZM13868@torch.brasslantern.com> (raw)
In-Reply-To: <110512101422.ZM13822@torch.brasslantern.com>
On May 12, 10:14am, Bart Schaefer wrote:
}
} 27 [[ "$_type$_noprefix" = options && ! -prefix [-+]* ]] && \
} 28 zstyle -T ":completion:${curcontext}:options" prefix-needed &&
} 29 return 1
}
} I'm not sure it's correct for it to entirely punt when prefix-needed
} is not defined. Probably the right thing would be to assume a default
} value instead ... but I don't really know.
Ah. Seems punting when not defined is equivalent to assuming a default
value of "true":
For command options, this means that the initial `-', `+', or `--'
must be typed explicitly before option names will be completed.
So changing _xset to use -O instead *is* the correct fix.
next prev parent reply other threads:[~2011-05-12 17:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-12 16:59 Mikael Magnusson
2011-05-12 17:14 ` Bart Schaefer
2011-05-12 17:22 ` Bart Schaefer [this message]
2011-05-12 17:40 ` Mikael Magnusson
2011-05-12 18:29 ` Bart Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=110512102212.ZM13868@torch.brasslantern.com \
--to=schaefer@brasslantern.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).