zsh-workers
 help / color / mirror / code / Atom feed
From: Bart Schaefer <schaefer@brasslantern.com>
To: <zsh-workers@zsh.org>
Subject: Re: XTRACE output -- I thought we'd fixed this?
Date: Mon, 23 May 2011 08:19:26 -0700	[thread overview]
Message-ID: <110523081926.ZM1957@torch.brasslantern.com> (raw)
In-Reply-To: <20110523101415.42244f06@pwslap01u.europe.root.pri>

On May 23, 10:14am, Peter Stephenson wrote:
} Subject: Re: XTRACE output -- I thought we'd fixed this?
}
} On Mon, 16 May 2011 14:28:43 -0700
} Bart Schaefer <schaefer@brasslantern.com> wrote:
} > Stderr redirection isn't supposed to redirect the xtrace descriptor
} > unless you use a { ... } construct.  There's even this in
} > exec.c:execcmd():
} > 
} >     /* Make a copy of stderr for xtrace output before redirecting */
} 
} I've been very confused by this, so it's quite possible something is
} still wrong.

The code to create a newxtrerr exec.c after line 2867 does get run,
and then the redirections happen, but then at line 3082 after closing
all the mnodes, we restore xtrerr to stderr again.  This was added
in the same patch that introduced the newxtrerr copy of xtrerr.  The
www.zsh.org web server is down so I can't check the archive; commit
log says:

revision 1.132
date: 2008/06/11 09:27:55;  author: pws;  state: Exp;  lines: +8 -7
25145: make sure XTRACE output is redirected with stderr

At this point, I'm also confused.  It appears zsh is deliberately
redirecting xtrace with stderr, whereas bash appears not to do so.


  reply	other threads:[~2011-05-23 15:19 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-16 21:28 Bart Schaefer
2011-05-23  9:14 ` Peter Stephenson
2011-05-23 15:19   ` Bart Schaefer [this message]
2011-05-24  6:16     ` PATCH (1 of 2): " Bart Schaefer
2011-05-24  6:35       ` PATCH (2 " Bart Schaefer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=110523081926.ZM1957@torch.brasslantern.com \
    --to=schaefer@brasslantern.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).