zsh-workers
 help / color / mirror / code / Atom feed
From: Bart Schaefer <schaefer@brasslantern.com>
To: <zsh-workers@zsh.org>
Subject: Recent curses module changes and Re: TRAPALRM / TMOUT oddity
Date: Thu, 26 May 2011 18:11:51 -0700	[thread overview]
Message-ID: <110526181151.ZM27246@torch.brasslantern.com> (raw)
In-Reply-To: <20110526101428.71e440e9@pwslap01u.europe.root.pri>

On May 26, 10:14am, Peter Stephenson wrote:
}
} +	    if (selret < 0 && (errflag || retflag || breaks || exit_pending))
}  		break;

I suppose that means the following would be advisable?  Or is it perhaps
going too far?

Index: Src/Modules/curses.c
===================================================================
diff -c -r1.5 curses.c
--- Src/Modules/curses.c	6 May 2011 15:29:06 -0000	1.5
+++ Src/Modules/curses.c	27 May 2011 01:08:59 -0000
@@ -1106,7 +1106,7 @@
 
 #ifdef HAVE_WGET_WCH
     while ((ret = wget_wch(w->win, &wi)) == ERR) {
-	if (errno != EINTR)
+	if (errno != EINTR || errflag || retflag || breaks || exit_pending)
 	    break;
     }
     switch (ret) {
@@ -1132,7 +1132,7 @@
     }
 #else
     while ((ci = wgetch(w->win)) == ERR) {
-	if (errno != EINTR)
+	if (errno != EINTR || errflag || retflag || breaks || exit_pending)
 	    return 1;
     }
     if (ci >= 256) {


  reply	other threads:[~2011-05-27  1:12 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-26  3:47 Bart Schaefer
2011-05-26  9:14 ` Peter Stephenson
2011-05-27  1:11   ` Bart Schaefer [this message]
2011-05-27  8:46     ` Recent curses module changes and " Peter Stephenson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=110526181151.ZM27246@torch.brasslantern.com \
    --to=schaefer@brasslantern.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).