From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-29390-mason-zsh=primenet.com.au@zsh.org>
Received: (qmail 9182 invoked by alias); 27 May 2011 04:41:17 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
X-Seq: 29390
Received: (qmail 22036 invoked from network); 27 May 2011 04:41:15 -0000
X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE
	autolearn=ham version=3.3.1
Received-SPF: none (ns1.primenet.com.au: domain at closedmail.com does not designate permitted sender hosts)
From: Bart Schaefer <schaefer@brasslantern.com>
Message-id: <110526214110.ZM518@torch.brasslantern.com>
Date: Thu, 26 May 2011 21:41:10 -0700
In-reply-to: <BANLkTimWC7jt3NudrWmnUhxkXMaLf+-+ww@mail.gmail.com>
Comments: In reply to Mikael Magnusson <mikachu@gmail.com>
 "Re: Problem with fake-files style and cd" (May 27,  3:25am)
References: <mikachu@gmail.com>
	<237967ef0902140622s7389d2c8h5a0c786dcf207422@mail.gmail.com>
	<200902141801.n1EI1E2l003603@pws-pc.ntlworld.com>
	<237967ef0902141019t30118690m30116c9413015d96@mail.gmail.com>
	<090214111316.ZM15188@torch.brasslantern.com>
	<237967ef0902141141y609b61d3i154546f6f6886c65@mail.gmail.com>
	<090214133904.ZM15383@torch.brasslantern.com>	<20090216094632.30502fe9@news01>
	<237967ef0902160155m583e714fqe9bbd344420f1ce0@mail.gmail.com>
	<BANLkTimWC7jt3NudrWmnUhxkXMaLf+-+ww@mail.gmail.com>
X-Mailer: OpenZMail Classic (0.9.2 24April2005)
To: zsh-workers <zsh-workers@zsh.org>
Subject: Re: Problem with fake-files style and cd
MIME-version: 1.0
Content-type: text/plain; charset=us-ascii

On May 27,  3:25am, Mikael Magnusson wrote:
}
} Been sitting on this patch for a while, is it okay to commit?

I feel a little silly mentioning these nits, but stylistically,

for names of directories DASH()- when the cdpath array is set,

would fit the context better.  There are no full-stops in any of
the other items in that list.  Also, you have "is used" in one
entry and "will be used" in the other.  (Prefer "is used".)

More substantively, remind me what "used instead" means here?  The
word "used" is not specific enough, I guess.