From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-29476-mason-zsh=primenet.com.au@zsh.org>
Received: (qmail 3199 invoked by alias); 13 Jun 2011 01:54:11 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
X-Seq: 29476
Received: (qmail 8416 invoked from network); 13 Jun 2011 01:54:00 -0000
X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE
	autolearn=ham version=3.3.1
Received-SPF: none (ns1.primenet.com.au: domain at closedmail.com does not designate permitted sender hosts)
From: Bart Schaefer <schaefer@brasslantern.com>
Message-id: <110612185339.ZM28551@torch.brasslantern.com>
Date: Sun, 12 Jun 2011 18:53:39 -0700
In-reply-to: <8662oaha3g.fsf@gmail.com>
Comments: In reply to Pan Tsu <inyaoo@gmail.com>
 "Re: killing suspended jobs makes zsh hang after 47d1215" (Jun 13,  4:02am)
References: <86aadnwtl2.fsf@gmail.com>
	<110612072211.ZM26399@torch.brasslantern.com>
	<110612075958.ZM27334@torch.brasslantern.com>	<8662oaha3g.fsf@gmail.com>
X-Mailer: OpenZMail Classic (0.9.2 24April2005)
To: zsh-workers@zsh.org
Subject: Re: killing suspended jobs makes zsh hang after 47d1215
Cc: Pan Tsu <inyaoo@gmail.com>
MIME-version: 1.0
Content-type: text/plain; charset=us-ascii

On Jun 13,  4:02am, Pan Tsu wrote:
}
}   % cat | cat &
}   [1] 91580 97756
}   [1]  + suspended (tty input)  cat | cat
}   % %
}   [1]  + continued  cat | cat
}   ^C
}   load: 0.06 no foreground process group
} 
}   (gdb) p pn->status
}   $1 = 19
}   (gdb) p WIFSIGNALED(pn->status)

So I begin to suspect that what we really want here is

Index: Src/jobs.c
--- Src/jobs.c.~1.83.~	2011-06-12 08:05:58.000000000 -0700
+++ Src/jobs.c	2011-06-12 18:51:37.000000000 -0700
@@ -190,7 +190,7 @@
 	     * to return in a different job.
 	     */
 	    if (pn->pid == pid && (pn->status == SP_RUNNING ||
-				   WIFSTOPPED(pn->status))) {
+				   !WIFEXITED(pn->status))) {
 		*pptr = pn;
 		*jptr = jobtab + i;
 		return 1;