* warn_create_global warnings in current trunk
@ 2011-09-09 21:35 Štěpán Němec
2011-09-09 21:47 ` Frank Terbeck
2011-09-10 2:25 ` Bart Schaefer
0 siblings, 2 replies; 4+ messages in thread
From: Štěpán Němec @ 2011-09-09 21:35 UTC (permalink / raw)
To: zsh-workers
Out of curiosity I've switched the option on in my .zshrc, and here are
the three warnings I'm getting (running recent trunk version; "created
globally in function" elided from the warning messages for conciseness):
compaudit:118: array parameter _i_ulwdirs
update_current_git_vars:4: scalar parameter _GIT_STATUS
update_current_git_vars:5: array parameter __CURRENT_GIT_STATUS
(I first thought about sending a patch, but after looking at compaudit I
figured leaving the fixes to the respective authors were the better
option.)
--
Štěpán
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: warn_create_global warnings in current trunk
2011-09-09 21:35 warn_create_global warnings in current trunk Štěpán Němec
@ 2011-09-09 21:47 ` Frank Terbeck
2011-09-10 9:07 ` Štěpán Němec
2011-09-10 2:25 ` Bart Schaefer
1 sibling, 1 reply; 4+ messages in thread
From: Frank Terbeck @ 2011-09-09 21:47 UTC (permalink / raw)
To: zsh-workers
Štěpán Němec wrote:
[...]
> compaudit:118: array parameter _i_ulwdirs
> update_current_git_vars:4: scalar parameter _GIT_STATUS
> update_current_git_vars:5: array parameter __CURRENT_GIT_STATUS
FWIW, the latter two are not part of zsh.
Regards, Frank
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: warn_create_global warnings in current trunk
2011-09-09 21:47 ` Frank Terbeck
@ 2011-09-10 9:07 ` Štěpán Němec
0 siblings, 0 replies; 4+ messages in thread
From: Štěpán Němec @ 2011-09-10 9:07 UTC (permalink / raw)
To: Frank Terbeck; +Cc: zsh-workers
On Fri, 09 Sep 2011 23:47:23 +0200
Frank Terbeck wrote:
> Štěpán Němec wrote:
> [...]
>> compaudit:118: array parameter _i_ulwdirs
>> update_current_git_vars:4: scalar parameter _GIT_STATUS
>> update_current_git_vars:5: array parameter __CURRENT_GIT_STATUS
>
> FWIW, the latter two are not part of zsh.
Ah, silly me. Those come from zsh-git-prompt* (and are easy to fix),
sorry.
* git://github.com/olivierverdier/zsh-git-prompt.git
(...and yeah, I do use vcs_info ;-))
--
Štěpán
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: warn_create_global warnings in current trunk
2011-09-09 21:35 warn_create_global warnings in current trunk Štěpán Němec
2011-09-09 21:47 ` Frank Terbeck
@ 2011-09-10 2:25 ` Bart Schaefer
1 sibling, 0 replies; 4+ messages in thread
From: Bart Schaefer @ 2011-09-10 2:25 UTC (permalink / raw)
To: zsh-workers
On Sep 9, 11:35pm, Stepan Nemec wrote:
}
} compaudit:118: array parameter _i_ulwdirs
That reveals quite a different bug. _i_ulwdirs is never referenced,
so the part of the Debian-specific code has been dead for a while.
Index: Completion/compaudit
===================================================================
RCS file: /cvsroot/zsh/zsh/Completion/compaudit,v
retrieving revision 1.10
diff -u -r1.10 compaudit
--- Completion/compaudit 20 Aug 2011 18:34:00 -0000 1.10
+++ Completion/compaudit 10 Sep 2011 02:24:39 -0000
@@ -102,7 +102,7 @@
# that this has not happened, and pick the best group.
if (( $#_i_wdirs )); then
- local GROUP GROUPMEM _i_pw _i_gid _i_ulwdirs
+ local GROUP GROUPMEM _i_pw _i_gid
if ((UID == EUID )); then
getent group $LOGNAME | IFS=: read GROUP _i_pw _i_gid GROUPMEM
else
@@ -117,8 +117,9 @@
if [[ -f /etc/debian_version ]]
then
-_i_ulwdirs=( ${(M)_i_wdirs:#/usr/local/*} )
-_i_wdirs=( ${_i_wdirs:#/usr/local/*} ${^_i_ulwdir}(Nf:g+ws:^g:staff:,f:o+w:,^u0) )
+ local _i_ulwdirs
+ _i_ulwdirs=( ${(M)_i_wdirs:#/usr/local/*} )
+ _i_wdirs=( ${_i_wdirs:#/usr/local/*} ${^_i_ulwdirs}(Nf:g+ws:^g:staff:,f:o+w:,^u0) )
fi
_i_wdirs=( $_i_wdirs ${^fpath}.zwc^([^_]*|*~)(N-^u0u${EUID}) )
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-09-10 9:12 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-09-09 21:35 warn_create_global warnings in current trunk Štěpán Němec
2011-09-09 21:47 ` Frank Terbeck
2011-09-10 9:07 ` Štěpán Němec
2011-09-10 2:25 ` Bart Schaefer
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).