From: Bart Schaefer <schaefer@brasslantern.com>
To: <zsh-workers@zsh.org>
Subject: Re: compadd --
Date: Tue, 25 Oct 2011 19:44:22 -0700 [thread overview]
Message-ID: <111025194422.ZM7846@torch.brasslantern.com> (raw)
In-Reply-To: <20111025172917.63f56967@pwslap01u.europe.root.pri>
On Oct 25, 5:29pm, Peter Stephenson wrote:
} Subject: Re: compadd --
}
} On Tue, 25 Oct 2011 09:04:45 -0700
} Bart Schaefer <schaefer@brasslantern.com> wrote:
} > BUILTIN("compadd", 0, bin_compadd, 0, -1, 0, NULL, NULL)
} >
} > says that compadd is going to do all its own option parsing.
}
} Except it doesn't. Are you saying we need this?
Oops, I'd forgotten about BINF_HANDLES_OPTS; I thought a NULL in the
opts slot meant there were no options and therefore the parser should
not remove any (including not removing "--").
Anyway that patch does appear to fix it.
} (Possibly for other completion functions?)
Well, having the generic option parser handle "--" was a change dating
from ... when? Sometime after 4.2.x ... and if we missed this one, we
may have missed others. But I'm having a hard time coming up with any
reasonable way to check other than going through it all by eye.
prev parent reply other threads:[~2011-10-26 2:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-25 14:33 foudfou
2011-10-25 16:04 ` Bart Schaefer
2011-10-25 16:29 ` Peter Stephenson
2011-10-26 2:44 ` Bart Schaefer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=111025194422.ZM7846@torch.brasslantern.com \
--to=schaefer@brasslantern.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).