From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14584 invoked by alias); 26 Oct 2011 02:44:47 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 29861 Received: (qmail 26209 invoked from network); 26 Oct 2011 02:44:44 -0000 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received-SPF: none (ns1.primenet.com.au: domain at closedmail.com does not designate permitted sender hosts) From: Bart Schaefer Message-id: <111025194422.ZM7846@torch.brasslantern.com> Date: Tue, 25 Oct 2011 19:44:22 -0700 In-reply-to: <20111025172917.63f56967@pwslap01u.europe.root.pri> Comments: In reply to Peter Stephenson "Re: compadd --" (Oct 25, 5:29pm) References: <111025090445.ZM1600@torch.brasslantern.com> <20111025172917.63f56967@pwslap01u.europe.root.pri> X-Mailer: OpenZMail Classic (0.9.2 24April2005) To: Subject: Re: compadd -- MIME-version: 1.0 Content-type: text/plain; charset=us-ascii On Oct 25, 5:29pm, Peter Stephenson wrote: } Subject: Re: compadd -- } } On Tue, 25 Oct 2011 09:04:45 -0700 } Bart Schaefer wrote: } > BUILTIN("compadd", 0, bin_compadd, 0, -1, 0, NULL, NULL) } > } > says that compadd is going to do all its own option parsing. } } Except it doesn't. Are you saying we need this? Oops, I'd forgotten about BINF_HANDLES_OPTS; I thought a NULL in the opts slot meant there were no options and therefore the parser should not remove any (including not removing "--"). Anyway that patch does appear to fix it. } (Possibly for other completion functions?) Well, having the generic option parser handle "--" was a change dating from ... when? Sometime after 4.2.x ... and if we missed this one, we may have missed others. But I'm having a hard time coming up with any reasonable way to check other than going through it all by eye.