From: Peter Stephenson <p.w.stephenson@ntlworld.com>
To: Stefan Radziuk <sradziuk@pdtpartners.com>, zsh-workers@zsh.org
Subject: Re: Using the history expansion modifier 'a' results in excessive lstat calls
Date: Wed, 25 May 2022 10:53:06 +0100 (BST) [thread overview]
Message-ID: <1126442111.366927.1653472386462@mail2.virginmedia.com> (raw)
In-Reply-To: <200084252.242457.1653041722599@mail2.virginmedia.com>
> On 20 May 2022 at 11:15 Peter Stephenson <p.w.stephenson@ntlworld.com> wrote:
> On 20 May 2022 at 11:08 Stefan Radziuk <sradziuk@pdtpartners.com> wrote:
> > I have looked through some threads in the mailing list to find out why
> > zgetdir > is being used over getcwd in the first place. It seems it was
> > implemented this way in the 1990s to work around a bug in some implementations
> > of getcwd, which should not be a concern on modern systems.
> >
> > I was wondering if zgetdir is still the right way to do this? Are there
> > use cases where it is preferred over getcwd? Maybe zgetcwd could simply
> > use getcwd primarily (i.e. not as fallback), or perhaps USE_GETCWD could
> > be enabled by default (currently it is only enabled on QNX builds).
>
> The best bet would probably be to try that by default once we're sure the
> release is out of the way --- as you say there's a good chance that's the
> right way to go now and I don't think we're going to find out the problems
> any other way.
Will it be worth seeing what effects the following has?
pws
diff --git a/configure.ac b/configure.ac
index c72148d06..77e381f50 100644
--- a/configure.ac
+++ b/configure.ac
@@ -2021,11 +2021,15 @@ if test x$zsh_cv_sys_superroot = xyes; then
fi
dnl CHECK FOR SYSTEMS REQUIRING GETCWD
+dnl This is now turned on by default, as we expect modern getcwd
+dnl implementations to work correctly. Any exceptions should be added
+dnl to the first case. Currently there are none, hence it is forced
+dnl not to match.
AC_CACHE_CHECK(whether we should use the native getcwd,
zsh_cv_use_getcwd,
[case "${host_cpu}-${host_vendor}-${host_os}" in
- *QNX*) zsh_cv_use_getcwd=yes ;;
- *) zsh_cv_use_getcwd=no ;;
+ *NOMATCH*) zsh_cv_use_getcwd=no ;;
+ *) zsh_cv_use_getcwd=yes ;;
esac])
AH_TEMPLATE([USE_GETCWD],
[Define to 1 if you need to use the native getcwd.])
next prev parent reply other threads:[~2022-05-25 9:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-20 10:08 Stefan Radziuk
2022-05-20 10:15 ` Peter Stephenson
2022-05-25 9:53 ` Peter Stephenson [this message]
2022-05-25 10:22 ` (EXT) " Stefan Radziuk
2022-05-25 10:33 ` Peter Stephenson
2022-05-26 8:35 ` Peter Stephenson
2022-05-20 10:34 ` Mikael Magnusson
2022-05-23 11:32 ` (EXT) " Stefan Radziuk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1126442111.366927.1653472386462@mail2.virginmedia.com \
--to=p.w.stephenson@ntlworld.com \
--cc=sradziuk@pdtpartners.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).