From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7163 invoked by alias); 8 May 2017 09:38:32 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 41059 Received: (qmail 6839 invoked from network); 8 May 2017 09:38:32 -0000 X-Qmail-Scanner-Diagnostics: from mail-wm0-f43.google.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(74.125.82.43):SA:0(0.5/5.0):. Processed in 1.053093 secs); 08 May 2017 09:38:32 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=0.5 required=5.0 tests=RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,RCVD_IN_SORBS_SPAM,SPF_PASS, T_DKIM_INVALID autolearn=no autolearn_force=no version=3.4.1 X-Envelope-From: jan.kryl@nexenta.com X-Qmail-Scanner-Mime-Attachments: |patch| X-Qmail-Scanner-Zip-Files: | Received-SPF: pass (ns1.primenet.com.au: SPF record at _netblocks.google.com designates 74.125.82.43 as permitted sender) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nexenta-com.20150623.gappssmtp.com; s=20150623; h=from:mime-version:subject:message-id:date:to; bh=Fs/12e7ueWnKbzvdSlOBrZvMzWBB6mG45KogxDLGmnM=; b=jq1NjiGzzDjDH9Vv4kO1xzz6c2DiDrd8eOFnROeI85Zd91TygJaAxbN981XtXLju0S rKITmlPLMnGyk9pvdoWQrrQwyK+PvJc3uA/D9p96ZaRfXgHL/exjKGMFHOR4bCdqvcm1 1eSFfWkWZqdyWe9+srSCTO+2jjNGBr1cQ2rsOCvRFlE/Rv0w1l55YQFcq1GUEiLlWyM5 UcRvpy6tUAK6dSfIV74ZZcWCaaKuRR+17NZ8N3UFL8RoI0kOClL1hbQSCQ2ykfH0hpv6 rkRyhb38weL/TDGOmmM5RjQXf//7dn4ySbE9medLoH08QbyNn+uC59g9ZeyCHuuY4AkQ K9bQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:mime-version:subject:message-id:date:to; bh=Fs/12e7ueWnKbzvdSlOBrZvMzWBB6mG45KogxDLGmnM=; b=dlC32S/mYdRN2QfX+Hetmibdabgkn9O5CCm2ehSpw5+sXTnYTRFGEYqigimG88JsXO 48M70yGmbxRRXALa4SUmcdePT6VWwPF0em52ZU6h2DnSVv4+E4KwBR4p1ys3tIvuA+U9 ZL3K+g1KnpB//cjqN7HQpaPrzUxhZCpeKjV3kSBEy9CZOAYN7DhmjUg7N/JcoOrLhIWD KQopoywvachDOmag0VKcArZ3rdJjIV2bmJfPyjb5ln0g40r8d+dIMa9Bqt2O10LC2YJx GefRLguHGVfVJPsef4jvfhiAks9L5lHgnvHtGy+NSNK2f+zi3T0s89vnq+GH1fFOF7qi 4wsw== X-Gm-Message-State: AODbwcBoX07gPJgBZu7RHyedO9xB+hnLYKu4T+blQpggXPeCj1BiPHKZ QFYpGovglLWSqBZMu2n8dQ== X-Received: by 10.28.228.212 with SMTP id b203mr6363268wmh.119.1494236303764; Mon, 08 May 2017 02:38:23 -0700 (PDT) From: Jan Kryl Content-Type: multipart/mixed; boundary="Apple-Mail=_75C925D6-7EEA-47ED-A32D-2C7CA00DD307" Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\)) Subject: autocompletion is broken in restricted shell Message-Id: <11381B06-E104-4785-8BB7-AC5E5B0296F0@nexenta.com> Date: Mon, 8 May 2017 11:38:37 +0200 To: zsh-workers@zsh.org X-Mailer: Apple Mail (2.3273) --Apple-Mail=_75C925D6-7EEA-47ED-A32D-2C7CA00DD307 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Hi, after we updated zsh to 5.3 autocompletion stopped to work for us in = restricted shell. This is mainly due to "38692: IFS can't be changed in restricted = mode=E2=80=9D. I suppose there is a good reason why setting IFS is not allowed in = restricted mode even though that it=E2=80=99s not apparent to me. However at least I would like to fix another thing which breaks = autocompletion and that is using write redirections in autocompletion code. That can be = avoided by using 2>&- instead of 2>/dev/null. A patch for review is attached. thanks -Jan --Apple-Mail=_75C925D6-7EEA-47ED-A32D-2C7CA00DD307 Content-Disposition: attachment; filename=patch Content-Type: application/octet-stream; x-unix-mode=0644; name="patch" Content-Transfer-Encoding: 7bit --- a/Completion/compinit Mon May 8 12:51:31 2017 +++ b/Completion/compinit Mon May 8 12:51:40 2017 @@ -168,7 +168,7 @@ _comp_caller_options=(${(kv)options[@]}); setopt localoptions localtraps localpatterns ${_comp_options[@]}; local IFS=$'\'\ \\t\\r\\n\\0\''; - builtin enable -p \| \~ \( \? \* \[ \< \^ \# 2>/dev/null; + builtin enable -p \| \~ \( \? \* \[ \< \^ \# 2>&-; exec