From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from primenet.com.au (ns1.primenet.com.au [203.24.36.2]) by inbox.vuxu.org (OpenSMTPD) with ESMTP id 543534b3 for ; Mon, 25 Mar 2019 14:37:31 +0000 (UTC) Received: (qmail 13087 invoked by alias); 25 Mar 2019 14:37:18 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 44177 Received: (qmail 4531 invoked by uid 1010); 25 Mar 2019 14:37:18 -0000 X-Qmail-Scanner-Diagnostics: from smtpq1.tb.ukmail.iss.as9143.net by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.101.1/25398. spamassassin: 3.4.2. Clear:RC:0(212.54.57.96):SA:0(-2.7/5.0):. Processed in 3.316177 secs); 25 Mar 2019 14:37:18 -0000 X-Envelope-From: p.w.stephenson@ntlworld.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: pass (ns1.primenet.com.au: SPF record at _mailcloud.virginmedia.com designates 212.54.57.96 as permitted sender) X-Env-Mailfrom: p.w.stephenson@ntlworld.com X-Env-Rcptto: zsh-workers@zsh.org X-SourceIP: 172.25.160.137 X-CNFS-Analysis: v=2.3 cv=Ee62v8uC c=1 sm=1 tr=0 a=wOjQ4in9RKFG6jhXMc4Ghg==:117 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=TdzEzxkPBUwA:10 a=IkcTkHD0fZMA:10 a=rpDhL_isVlsA:10 a=hD80L64hAAAA:8 a=dq1smn4Eh1vWvzrwocAA:9 a=QEXdDO2ut3YA:10 X-Authenticated-Sender: p.w.stephenson@ntlworld.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ntlworld.com; s=meg.feb2017; t=1553524596; bh=yB/x5XO5IqFbRGKd7x6eli2JtgCQ0oRx71T6fWJZS3c=; h=Date:From:To:In-Reply-To:References:Subject; b=feGdB++VzCYF5NFJd6qQiJ22hhIEXor+8u6VB/pPyanbvVR0aZxlzPjdn333vT6gC K0CnNlGjHEf645YtFLL+RVb87eIPzqlfUHAxpTg1xXtF0wffYN2LJ1GHEJAQ6/e80b iv8eFCfhfjwUVxZnyFdnbiRNnzKJshzJwd5OjKO1TpIqa53NZxDEzvgBiEwwx6D278 IjXuhjQLW3YHcupuk+aHUoYi1AM81wp75pSYRBf5v+MiIyvMaHcEzvD8WlrJWL8VBt 8FYL4L0KehBm8sq5FL2JW4TNEeh7xPljf/oKxiH0JpRtKKbwa/KgGBa2GNzrRSjGvh Do2UrixWP2jsQ== Date: Mon, 25 Mar 2019 14:36:36 +0000 (GMT) From: Peter Stephenson To: zsh-workers@zsh.org Message-ID: <1164333478.906060.1553524596824@mail2.virginmedia.com> In-Reply-To: <72612202-4F1F-4B1F-ABAE-1CF730AF1A2F@kba.biglobe.ne.jp> References: <20190323101135.14344-1-wesley@mintlab.nl> <20190323101135.14344-2-wesley@mintlab.nl> <1553517734.6561.2.camel@samsung.com> <72612202-4F1F-4B1F-ABAE-1CF730AF1A2F@kba.biglobe.ne.jp> Subject: Re: [PATCH] Change handrolled strftime to strftime in zftp.c MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Priority: 3 Importance: Medium X-Mailer: Open-Xchange Mailer v7.8.4-Rev51 X-Originating-IP: 165.225.81.34 X-Originating-Client: open-xchange-appsuite X-CMAE-Envelope: MS4wfAiSjg8h8CCEu4dHiECT4zgVt02WwKWuCT0DxK7uNRPzd96yQcEbr5uXio/EV/XcLY2eeQafexlrHjlMYq29YhcC8pFA5/NSl+qS3H6ch0mIIyA/IQQ8 D+ZrsLbFkzhNrafkXH8sskg3Y/SU627qXzjVV31M006RlIbuYkN6uGZnvvzy7IsMCHIRJGoa7U2903vo1+lfh4TjAEawsdodrY8= > On 25 March 2019 at 13:07 "Jun T." wrote: > > 2019/03/25 21:42, Peter Stephenson wrote: > >> > >> Should we replace "#ifdef OFF_T_IS_64_BIT" by "#ifndef OFF_T_IS_64_BIT"? > > > > The obvious test would be > > > > #ifdef ZSH_64_BIT_TYPE > > But ZSH_64_BIT_TYPE is defined only if long is 32 bit > so we still get 'Shell compiled with wrong off_t size'. > Do you mean "#ifndef ZSH_64_BIT_TYPE"? I don't see how that could work since output64() wouldn't exist. I think this means the error message in the other branch is now redundant --- if long is a 64-bit value it's perfectly OK to use that code. Could change the DPUTS check to check sizeof(sz) for that purpose instead? pws