From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from primenet.com.au (ns1.primenet.com.au [203.24.36.2]) by inbox.vuxu.org (OpenSMTPD) with ESMTP id 1285aff3 for ; Mon, 25 Feb 2019 19:14:58 +0000 (UTC) Received: (qmail 22240 invoked by alias); 25 Feb 2019 19:14:39 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 44083 Received: (qmail 25579 invoked by uid 1010); 25 Feb 2019 19:14:39 -0000 X-Qmail-Scanner-Diagnostics: from mail-it1-f194.google.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.100.2/25370. spamassassin: 3.4.2. Clear:RC:0(209.85.166.194):SA:0(-1.9/5.0):. Processed in 2.250083 secs); 25 Feb 2019 19:14:39 -0000 X-Envelope-From: dana@dana.is X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: pass (ns1.primenet.com.au: SPF record at _netblocks.google.com designates 209.85.166.194 as permitted sender) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dana-is.20150623.gappssmtp.com; s=20150623; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=YQiEkMpmOCp30Q4ZbvvXC5y5n2iQ8lZgUm38J9hCH+o=; b=KPPBApzOqxsb6jp/m7Xa5K4RfVXbR6+DVtJlC0tKfY/v5nD4BsKTTIB1PgqXY7XAqr nYQA1pn2+JRS6o3mOc/LRdgPbb9A45UNY9nJnCbwHtL/iWVZnP4fLsWwJNdIXayQqaNU /Xd4EwZXNbqLbVbjjTY5QjD6ZDkWcovU8RygrwfMX9XeXCLyM8icETM6dbcN70CMCFf3 iwqTGh1CWgA/KHFoRP9H/ipR2wz8XtSTyzIMgqntM1k1C0Sze4fwMW5t6atxUYsG+pyn Gp6e1rZqup05TBRk/Zbvt4yglTg3pYbOJ8qAb0kc4BU+K3glRhNLDwxhs5ozXIUbsdEg Uy3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=YQiEkMpmOCp30Q4ZbvvXC5y5n2iQ8lZgUm38J9hCH+o=; b=Z7YxGy04KDyJoShHl/uOl8r9s2qowfwbp+heJJPGQEb/XbcOZSlrHWM7fmhB3lZar9 JlFWr7S/FCZmaSZ3wkT6b2fKGodz0Q5QQzs9AOq2fM1xtUx0Ib63U0w9F4Eo446pxgaH SjVL1dJtPNZNTgbAE1306PtBYonr2mcnjqgXub6BNZ3XDprso/MScMcProMn8lKjA5Dj DSr3R3G411nfFhvnDy0vsoJ1pHcYXKlkLf72QU+X5ay3HPOPPMNLtYxS8xylMRQT6iZ7 CsvBl6InMZhzVhns3r0nceUW27vzTPLsSEigIGSnU/vf4a4czCNDsJDru0kjn+TG5ydx aXwg== X-Gm-Message-State: AHQUAuZ+NxPnrjldWqc4LjftiKSyuga0LJASzrp9jBScxbBDGJjAtIwB 9ZM1XF/A3k4tf9aY2MfWlNvxlA== X-Google-Smtp-Source: AHgI3IbFIajl/mYUYwWgZgoFiW7WCjXp785imavzjOIIIklzahNM8XizuxhGTYNEQ/aApxLGYBqe9g== X-Received: by 2002:a02:5546:: with SMTP id e67mr4407790jab.10.1551122042751; Mon, 25 Feb 2019 11:14:02 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\)) Subject: Re: RFC: [PATCH] Completion/Unix/Command/_git: replace a few "*::" with "*:" From: dana In-Reply-To: Date: Mon, 25 Feb 2019 13:14:01 -0600 Cc: Zsh Hackers' List Content-Transfer-Encoding: 7bit Message-Id: <11F88813-0A73-459B-825D-B5805870ABB8@dana.is> References: <20190224135854.3905-1-genml+zsh-workers@thequod.de> <57F7B086-B935-4E12-8FEA-A2F232EEDB43@dana.is> To: Daniel Hahler X-Mailer: Apple Mail (2.3445.9.1) On 25 Feb 2019, at 04:04, Daniel Hahler wrote: >As for _git_checkout, the following appears to work better: >... >- '*:: :->branch-or-tree-ish-or-file' && ret=0 >+ '1: :->first-arg' \ >+ '*: :->other-arg' && ret=0 I only played with it for a second, but yes, that seems better to me. It does produce a 'not a git repository' message when you complete options, though, which is slightly irritating. I guess you could re-add that -* prefix check there, can't think of anything nicer right now Your white space is broken, also. That file does have some tabs in it, but mostly it's spaces dana