From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-30352-mason-zsh=primenet.com.au@zsh.org>
Received: (qmail 18441 invoked by alias); 12 Mar 2012 17:08:06 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
X-Seq: 30352
Received: (qmail 19978 invoked from network); 12 Mar 2012 17:08:03 -0000
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE
	autolearn=ham version=3.3.2
Received-SPF: none (ns1.primenet.com.au: domain at closedmail.com does not designate permitted sender hosts)
From: Bart Schaefer <schaefer@brasslantern.com>
Message-id: <120312100737.ZM22728@torch.brasslantern.com>
Date: Mon, 12 Mar 2012 10:07:37 -0700
In-reply-to: <20120312111028.7b1edca2@pwslap01u.europe.root.pri>
Comments: In reply to Peter Stephenson <Peter.Stephenson@csr.com>
 "Re: Certain unicode in hostname breaks with zsh 4.3.17" (Mar 12, 11:10am)
References:
 <CAGO9HBhuTRJtxLvYgn3bgQ-1XO9OmEnE0SHmxzyWvwGPX_1V=g@mail.gmail.com>
	<CAH+w=7aqJcqgE=Oq_8CvrfCJazACVcXBHALP5YhBw6qR-ND=eA@mail.gmail.com>
	<CAH+w=7YptzOCFwG3u3g-CvyyenDUFea8rpm7o5g6gzyFzJGx7w@mail.gmail.com>
	<CAHYJk3TbR4S8NLbH7rut_uf0OBJg_vDzpZFwAqwoDcDBUkab7A@mail.gmail.com>
	<120311141935.ZM12005@torch.brasslantern.com>
	<CAHYJk3Q6RYa2gMQGy1Jr98zj3OxQzKMGGiUmcor=BMHcH46NgQ@mail.gmail.com>
	<120311205638.ZM21245@torch.brasslantern.com>
	<20120312100831.0bb82360@pwslap01u.europe.root.pri>
	<20120312111028.7b1edca2@pwslap01u.europe.root.pri>
X-Mailer: OpenZMail Classic (0.9.2 24April2005)
To: <zsh-workers@zsh.org>
Subject: Re: Certain unicode in hostname breaks with zsh 4.3.17
MIME-version: 1.0
Content-type: text/plain; charset=us-ascii

On Mar 12, 11:10am, Peter Stephenson wrote:
>
> @@ -739,7 +741,7 @@ createparamtable(void)
>  			pm->env = mkenvstr (pm->node.nam,
>  					    getsparam(pm->node.nam), pm->node.flags);
>  		    else
> -			pm->env = ztrdup(*envp2);
> +			pm->env = ztrdup_metafy(*envp2);
>  #ifndef USE_SET_UNSET_ENV
>  		    *envp++ = pm->env;
>  #endif

I'm not sure that's correct.  pm->env is being copied directly into the
global environ array in the USE_SET_UNSET_ENV case.  Surely it'll play
havok to put metafied strings into the environment of forked children?
Or is that cleaned up somewhere else?