From: Bart Schaefer <schaefer@brasslantern.com>
To: "zsh-workers@zsh.org" <zsh-workers@zsh.org>
Subject: Re: Problems with zargs (Was: xargs should be a builtin)
Date: Thu, 12 Apr 2012 16:05:10 -0700 [thread overview]
Message-ID: <120412160510.ZM1863@torch.brasslantern.com> (raw)
In-Reply-To: <20120411100642.GA8180@chaz.gmail.com>
On Apr 11, 11:06am, Stephane Chazelas wrote:
}
} By the way, there seems to be some issues with zargs:
}
} ~$ zargs a b '' -- print -rl
} a
} b
} ~$ zargs a -- print -rl ''
} a
Hmm, empty strings are being collapsed out of $argv[end+1,-1] when it
is assigned. I'm not remembering whether that's expected or something
new. Patch below, though it probably needs some more test cases.
} ~$ zargs -e a '' print -rl
} a print -rl
} ~$ zargs --eof= a '' print -rl
} a
This is actually the expected behavior. "zargs --help":
--eof[=eof-str], -e[eof-str]
Change the end-of-input-args string from "--" to eof-str. If
given as --eof=, an empty argument is the end; as --eof or -e,
with no (or an empty) eof-str, all arguments are input-args.
Index: Functions/Misc/zargs
===================================================================
retrieving revision 1.6
diff -c -r1.6 zargs
--- zargs 20 Dec 2011 17:13:38 -0000 1.6
+++ zargs 12 Apr 2012 22:48:19 -0000
@@ -167,11 +167,11 @@
elif (( $#eof )); then end=$argv[(i)${eof##-(e|-eof=)}]
else end=$argv[(i)--]
fi
-local -a args call command; command=( ${argv[end+1,-1]} )
+local -a args call command; command=( "${(@)argv[end+1,-1]}" )
if (( $opts[(I)-(null|0)] ))
-then set -- ${(ps:\000:)argv[1,end-1]}
-else set -- $argv[1,end-1]
+then set -- "${(@ps:\000:)argv[1,end-1]}"
+else set -- "${(@)argv[1,end-1]}"
fi
if [[ -n $command ]]
@@ -187,7 +187,7 @@
then print -u2 -r -- "$call"
fi
eval "{
- \$call
+ ${(@qq)call}
} $bg"'
local ret=0 analyze='
case $? in
@@ -205,7 +205,7 @@
if (( $opts[(I)-(-no-run-if-empty|r)] ))
then return 0
else
- call=($command)
+ call=( "${(@)command}" )
# Use "repeat" here so "continue" won't complain.
repeat 1; do eval "$execute ; $analyze"; done
return $ret
@@ -275,11 +275,11 @@
((ARGC)) || break
for (( end=l; end && ${(c)#argv[1,end]} > s; end/=2 )) { }
(( end > n && ( end = n ) ))
- args=( $argv[1,end] )
+ args=( "${(@)argv[1,end]}" )
shift $((end > ARGC ? ARGC : end))
if (( $#i ))
- then call=( ${command/$i/$args} )
- else call=( $command $args )
+ then call=( "${(@)command/$i/$args}" )
+ else call=( "${(@)command}" "${(@)args}" )
fi
if (( ${(c)#call} > s ))
then
prev parent reply other threads:[~2012-04-13 7:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-11 7:31 xargs should be a builtin Dave Yost
2012-04-11 7:44 ` Frank Terbeck
2012-04-11 10:06 ` Problems with zargs (Was: xargs should be a builtin) Stephane Chazelas
2012-04-11 16:15 ` Peter Stephenson
2012-04-12 9:28 ` Stephane Chazelas
2012-04-12 19:33 ` Peter Stephenson
[not found] ` <CAH+w=7Z5pUmqxpURyHMA5FX3hMGoyQeYwbC1N7AO6Ow-D=P-gw@mail.gmail.com>
[not found] ` <20120413201325.64cfcd1f@pws-pc.ntlworld.com>
2012-04-14 17:01 ` Bart Schaefer
2012-04-12 23:05 ` Bart Schaefer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=120412160510.ZM1863@torch.brasslantern.com \
--to=schaefer@brasslantern.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).