From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-30530-mason-zsh=primenet.com.au@zsh.org>
Received: (qmail 27799 invoked by alias); 26 Jun 2012 07:21:24 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
X-Seq: 30530
Received: (qmail 23674 invoked from network); 26 Jun 2012 07:21:22 -0000
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE
	autolearn=ham version=3.3.2
Received-SPF: none (ns1.primenet.com.au: domain at closedmail.com does not designate permitted sender hosts)
From: Bart Schaefer <schaefer@brasslantern.com>
Message-id: <120626002100.ZM19208@torch.brasslantern.com>
Date: Tue, 26 Jun 2012 00:21:00 -0700
In-reply-to: <120626000311.ZM19019@torch.brasslantern.com>
Comments: In reply to Bart Schaefer <schaefer@brasslantern.com>
 "Re: crashes when setting COLUMNS=0 or 1" (Jun 26, 12:03am)
References: <BANLkTimx-EEcmUFcfiM0W2=kaPSoCK=RUg@mail.gmail.com>
	<20120626033802.GA3066@primenet.com.au>
	<120626000311.ZM19019@torch.brasslantern.com>
X-Mailer: OpenZMail Classic (0.9.2 24April2005)
To: zsh workers <zsh-workers@zsh.org>
Subject: Re: crashes when setting COLUMNS=0 or 1
MIME-version: 1.0
Content-type: text/plain; charset=us-ascii

On Jun 26, 12:03am, Bart Schaefer wrote:
}
} IPDEF5("COLUMNS", &zterm_columns, zlevar_gsu)

Oh, for pity's sake.  The definition of IPDEF5 never references the F
argument.

Index: Src/params.c
===================================================================
RCS file: /extra/cvsroot/zsh/zsh-4.0/Src/params.c,v
retrieving revision 1.48
diff -u -r1.48 params.c
--- Src/params.c        20 Dec 2011 17:13:38 -0000      1.48
+++ Src/params.c        26 Jun 2012 07:18:22 -0000
@@ -315,7 +315,7 @@
 IPDEF4("PPID", &ppid),
 IPDEF4("ZSH_SUBSHELL", &zsh_subshell),
 
-#define IPDEF5(A,B,F) {{NULL,A,PM_INTEGER|PM_SPECIAL},BR((void *)B),GSU(varinteger_gsu),10,0,NULL,NULL,NULL,0}
+#define IPDEF5(A,B,F) {{NULL,A,PM_INTEGER|PM_SPECIAL},BR((void *)B),GSU(F),10,0,NULL,NULL,NULL,0}
 IPDEF5("COLUMNS", &zterm_columns, zlevar_gsu),
 IPDEF5("LINES", &zterm_lines, zlevar_gsu),
 IPDEF5("OPTIND", &zoptind, varinteger_gsu),