zsh-workers
 help / color / mirror / code / Atom feed
From: Bart Schaefer <schaefer@brasslantern.com>
To: zsh workers <zsh-workers@zsh.org>
Subject: Re: typeset -F3 SECONDS doesn't work the first time
Date: Thu, 28 Jun 2012 09:54:03 -0700	[thread overview]
Message-ID: <120628095403.ZM27189@torch.brasslantern.com> (raw)
In-Reply-To: <CAHYJk3TR6G2WPy_u3n=64yYXuW9XsH1UPqPwqKCQSHpYXRD5Fg@mail.gmail.com>

On Jun 27,  7:58pm, Mikael Magnusson wrote:
}
} >                 } else if (!setsecondstype(pm, on, off)) {
} >                     if (value && !setsparam(pname, ztrdup(value)))
} >                         return NULL;
} >                     /* return pm; */
} >                     usepm = 1;
} >                     err = 0;
} >                 }
} >
} > (Not provided as a patch because I don't have time right now to test it.)
} 
} This appears to work.

I've now tried this with various typeset flags, assigning a value to
SECONDS in the typeset call, etc., and haven't gotten it to break.

Is there any circumstance in which setsparam() [which is a macro around
assignsparam()] could render pm invalid?  It doesn't look like it from
examination of the code, but maybe this should be

                } else if (!setsecondstype(pm, on, off)) {
                    if (value && !(pm = setsparam(pname, ztrdup(value))))
                        return NULL;
                    usepm = 1;
                    err = 0;
                }

(Note the assignment to pm.)

Aside:  Exporting SECONDS doesn't do what you might think.  The value at
the time of the export is enshrined in the environment and never changes,
and is thereafter the starting clock for newly-started shells.


  reply	other threads:[~2012-06-28 16:54 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-26 16:26 Mikael Magnusson
2012-06-27 17:50 ` Bart Schaefer
2012-06-27 17:58   ` Mikael Magnusson
2012-06-28 16:54     ` Bart Schaefer [this message]
2012-06-28 17:04       ` Mikael Magnusson
2012-06-28 18:06         ` Bart Schaefer
2012-06-28 18:11           ` Mikael Magnusson
2012-06-28 22:00             ` Bart Schaefer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=120628095403.ZM27189@torch.brasslantern.com \
    --to=schaefer@brasslantern.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).