zsh-workers
 help / color / mirror / code / Atom feed
From: "Jörg Sommer" <joerg@alea.gnuu.de>
To: zsh-workers@sunsite.dk
Cc: "Jörg Sommer" <joerg@alea.gnuu.de>
Subject: [PATCH] Quote components before using it is pattern
Date: Tue, 14 Oct 2008 01:01:33 +0200	[thread overview]
Message-ID: <1223938893-2537-1-git-send-email-joerg@alea.gnuu.de> (raw)

A component might contain a character active in patterns, like * or ().
Take for example the path /tmp/foobar). Passing this and /tmp/foo123 as a
completion to _multi_parts results in an error:

_multi_parts:147: bad pattern: (foo123|foobar))*

The characters in the temporary variable tmp1 must be quote, before the
pattern is build with them.
---
 Completion/Base/Utility/_multi_parts |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/Completion/Base/Utility/_multi_parts b/Completion/Base/Utility/_multi_parts
index 615ef79..6fb6cbd 100644
--- a/Completion/Base/Utility/_multi_parts
+++ b/Completion/Base/Utility/_multi_parts
@@ -144,7 +144,7 @@ while true; do
 	SUFFIX="$suf"
       fi
 
-      matches=( "${(@M)matches:#(${(j:|:)~tmp1})*}" )
+      matches=( "${(@M)matches:#(${(j:|:)~${(q)tmp1}})*}" )
 
       if ! zstyle -t ":completion:${curcontext}:" expand suffix ||
          [[ -n "$menu" || -z "$compstate[insert]" ]]; then
-- 
1.6.0.2


             reply	other threads:[~2008-10-13 23:03 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-13 23:01 Jörg Sommer [this message]
2008-10-14 15:01 ` Jörg Sommer
2010-08-21 12:46   ` Mikael Magnusson
2010-08-21 16:54     ` Bart Schaefer
2010-08-21 17:04       ` Mikael Magnusson
2010-08-21 17:12       ` Bart Schaefer
2010-08-21 17:25         ` Mikael Magnusson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1223938893-2537-1-git-send-email-joerg@alea.gnuu.de \
    --to=joerg@alea.gnuu.de \
    --cc=zsh-workers@sunsite.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).