zsh-workers
 help / color / mirror / code / Atom feed
From: "Jörg Sommer" <joerg@alea.gnuu.de>
To: zsh-workers@sunsite.dk
Cc: "Jörg Sommer" <joerg@alea.gnuu.de>
Subject: [PATCH] modprobe: Complete loaded modules if nothing was found
Date: Mon, 12 Jan 2009 00:44:19 +0100	[thread overview]
Message-ID: <1231717459-21637-1-git-send-email-joerg@alea.gnuu.de> (raw)

In some cases it is useful when Zsh does complete the module names while
they aren't loadable. A module can't be loaded twice, so Zsh doesn't
suggest modules they are already loaded. But for commands like this it is
helpful:

% rmmod snd_seq_device; modprobe snd_seq_device
---
 Completion/Linux/Command/_modutils |    9 ++++++++-
 1 files changed, 8 insertions(+), 1 deletions(-)

diff --git a/Completion/Linux/Command/_modutils b/Completion/Linux/Command/_modutils
index eefb11f..40399ab 100644
--- a/Completion/Linux/Command/_modutils
+++ b/Completion/Linux/Command/_modutils
@@ -87,7 +87,14 @@ case "$state" in
     _tags files modules
     while _tags; do
       _requested files expl "module file"  _files -g '*.ko' && ret=0
-      _requested modules expl module compadd -a modules && ret=0
+      if _requested modules expl module; then
+          if compadd -a modules; then
+              ret=0
+          else
+              [[ $state = loadable_modules ]] && \
+                compadd -a loaded_modules && ret=0
+          fi
+      fi
     done
   ;;
 
-- 
1.6.0.6


             reply	other threads:[~2009-01-11 23:49 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-11 23:44 Jörg Sommer [this message]
2009-01-25 20:45 Jörg Sommer
2009-01-26  3:29 ` Andrey Borzenkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1231717459-21637-1-git-send-email-joerg@alea.gnuu.de \
    --to=joerg@alea.gnuu.de \
    --cc=zsh-workers@sunsite.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).