[PATCH] modprobe: Complete loaded modules if nothing was found

[PATCH] modprobe: Complete loaded modules if nothing was found

[Jörg Sommer]

In some cases it is useful when Zsh does complete the module names while
they aren't loadable. A module can't be loaded twice, so Zsh doesn't
suggest modules they are already loaded. But for commands like this it is
helpful:

% rmmod snd_seq_device; modprobe snd_seq_device
---
 Completion/Linux/Command/_modutils |    9 ++++++++-
 1 files changed, 8 insertions(+), 1 deletions(-)

diff --git a/Completion/Linux/Command/_modutils b/Completion/Linux/Command/_modutils
index eefb11f..40399ab 100644
--- a/Completion/Linux/Command/_modutils
+++ b/Completion/Linux/Command/_modutils
@@ -87,7 +87,14 @@ case "$state" in
     _tags files modules
     while _tags; do
       _requested files expl "module file"  _files -g '*.ko' && ret=0
-      _requested modules expl module compadd -a modules && ret=0
+      if _requested modules expl module; then
+          if compadd -a modules; then
+              ret=0
+          else
+              [[ $state = loadable_modules ]] && \
+                compadd -a loaded_modules && ret=0
+          fi
+      fi
     done
   ;;
 
-- 
1.6.0.6

[PATCH] modprobe: Complete loaded modules if nothing was found

[Jörg Sommer]

In some cases it is useful when Zsh does complete the module names while
they aren't loadable. A module can't be loaded twice, so Zsh doesn't
suggest modules they are already loaded. But for commands like this it is
helpful:

% rmmod snd_seq_device; modprobe snd_seq_device
---
 Completion/Linux/Command/_modutils |    9 ++++++++-
 1 files changed, 8 insertions(+), 1 deletions(-)

diff --git a/Completion/Linux/Command/_modutils b/Completion/Linux/Command/_modutils
index eefb11f..40399ab 100644
--- a/Completion/Linux/Command/_modutils
+++ b/Completion/Linux/Command/_modutils
@@ -87,7 +87,14 @@ case "$state" in
     _tags files modules
     while _tags; do
       _requested files expl "module file"  _files -g '*.ko' && ret=0
-      _requested modules expl module compadd -a modules && ret=0
+      if _requested modules expl module; then
+          if compadd -a modules; then
+              ret=0
+          else
+              [[ $state = loadable_modules ]] && \
+                compadd -a loaded_modules && ret=0
+          fi
+      fi
     done
   ;;
 
-- 
1.6.0.6

Re: [PATCH] modprobe: Complete loaded modules if nothing was found

[Andrey Borzenkov]

[-- Attachment #1: Type: text/plain, Size: 1608 bytes --]

On 25 января 2009 23:45:06 Jörg Sommer wrote:
> In some cases it is useful when Zsh does complete the module names
> while they aren't loadable. A module can't be loaded twice, so Zsh
> doesn't suggest modules they are already loaded. But for commands
> like this it is helpful:
>
> % rmmod snd_seq_device; modprobe snd_seq_device

I am afraid this is close to "let's make shell read my mind". This 
is very exotic case and (personally) I prefer to press ENTER after rmmod 
- simply because rmmod may fail and I want to know it.

I'd rather see modules completion synced with current module-init-tools 
:) One obviously missing feature is completing modules from kernel 
different from currently running (modinfo -k) 

> ---
>  Completion/Linux/Command/_modutils |    9 ++++++++-
>  1 files changed, 8 insertions(+), 1 deletions(-)
>
> diff --git a/Completion/Linux/Command/_modutils
> b/Completion/Linux/Command/_modutils index eefb11f..40399ab 100644
> --- a/Completion/Linux/Command/_modutils
> +++ b/Completion/Linux/Command/_modutils
> @@ -87,7 +87,14 @@ case "$state" in
>      _tags files modules
>      while _tags; do
>        _requested files expl "module file"  _files -g '*.ko' && ret=0
> -      _requested modules expl module compadd -a modules && ret=0
> +      if _requested modules expl module; then
> +          if compadd -a modules; then
> +              ret=0
> +          else
> +              [[ $state = loadable_modules ]] && \
> +                compadd -a loaded_modules && ret=0
> +          fi
> +      fi
>      done
>    ;;





[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 197 bytes --]