help / color / mirror / code / Atom feed
From: Peter Stephenson <p.w.stephenson@ntlworld.com>
To: Zsh hackers list <zsh-workers@zsh.org>
Subject: Re: [PATCH] Named reference typos & misc.
Date: Tue, 14 Feb 2023 14:46:59 +0000 (GMT)	[thread overview]
Message-ID: <1249162537.4244630.1676386019653@mail.virginmedia.com> (raw)
In-Reply-To: <CAH+w=7YRxyV6sj4eobpgo3aEgw3MOZj6jJ9bhi+acJn=ywbVAA@mail.gmail.com>

> On 14/02/2023 02:08 Bart Schaefer <schaefer@brasslantern.com> wrote:
> More stuff helpfully noticed by Oliver; the last patch unintentionally
> regressed one valid assignment usage, typeset +m and $parameters
> returned (different) incorrect results for named references, and
> testing for typeset +m revealed a segfault with typeset -p.

I need the following to make the tests pass --- else no error message.
It's possible I'm missing something, I'm not following every detail
here but it looks like everything is committed up to date so probably
worth mentioning.  I won't commit this since Bart will know if this
reflects a more fundamental problem.

diff --git a/Test/K01nameref.ztst b/Test/K01nameref.ztst
index d240e49..38a5fbd 100644
--- a/Test/K01nameref.ztst
+++ b/Test/K01nameref.ztst
@@ -651,6 +651,7 @@ F:Same test, should part 5 output look like this?
 >typeset -n ref=two
 >typeset -n ref=var
+ unsetopt typeset_to_unset
  unset -n ref
  unset one
  typeset -n ref


  reply	other threads:[~2023-02-14 14:47 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-14  2:08 Bart Schaefer
2023-02-14 14:46 ` Peter Stephenson [this message]
2023-02-14 16:14   ` Bart Schaefer
2023-02-14 16:36     ` Peter Stephenson
2023-02-14 20:00       ` Bart Schaefer
2023-02-15  1:39         ` Bart Schaefer
2023-02-16 15:29           ` zmodload (-u?) changing options (was Re: [PATCH] Named reference typos & misc.) Bart Schaefer
2023-02-16 15:52             ` Peter Stephenson
2023-02-16 18:17               ` Bart Schaefer
2023-02-16 19:28                 ` Bart Schaefer
2023-02-16 23:10                 ` Bart Schaefer
2023-02-21 11:47                 ` Peter Stephenson
2023-02-21 12:11                   ` Peter Stephenson
2023-02-21 15:57                     ` Bart Schaefer
2023-02-15 10:12         ` [PATCH] Named reference typos & misc Peter Stephenson
2023-02-15 10:36           ` Peter Stephenson
2023-02-15 14:58             ` Bart Schaefer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1249162537.4244630.1676386019653@mail.virginmedia.com \
    --to=p.w.stephenson@ntlworld.com \
    --cc=zsh-workers@zsh.org \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).