Sven's patches (16990, 16991, and users/4836)

Sven's patches (16990, 16991, and users/4836)

[Bart Schaefer]

Seems like these should go on the 4.0 patches branch, too?

Re: Sven's patches (16990, 16991, and users/4836)

[Sven Wischnowsky]

Bart Schaefer wrote:

> Seems like these should go on the 4.0 patches branch, too?

Right, I always forget. I've committed them to the branch -- I don't
remember: was I supposed to do that or is some dedicated person in
control of it?


Bye
  Sven

-- 
Sven Wischnowsky                          wischnow@berkom.de

Re: Sven's patches (16990, 16991, and users/4836)

[Bart Schaefer]

On Apr 16,  4:54pm, Sven Wischnowsky wrote:
}
} Bart Schaefer wrote:
} 
} Right, I always forget. I've committed them to the branch -- I don't
} remember: was I supposed to do that or is some dedicated person in
} control of it?

We had said that commits to the patches branch should be approved by
somebody appropriate -- and that you were the appropriate person for
completion system approvals, so it's quite all right that you did this
commit.

However, people have not been rigorously adhering to the "get approval
before committing to the patches branch" procedure.  So far it doesn't
seem to have caused any problem.

-- 
Bart Schaefer                                 Brass Lantern Enterprises
http://www.well.com/user/barts              http://www.brasslantern.com

Zsh: http://www.zsh.org | PHPerl Project: http://phperl.sourceforge.net   

Re: Forgetting the 4.0-patch branch

[Wayne Davison]

Speaking of which, a few of my recent fixes should really go onto the
patch branch.  Shall I get some approval first?  I'd particularly like
to apply the anti-truncation fixes in 16890 and users/4678, the unposted
HISTSIZE-can't-go-below-2 fix, and possibly the latter half of 16703
(which made the "history" command better in boundary conditions).

..wayne..

Re: Forgetting the 4.0-patch branch

[Peter Stephenson]

Wayne Davison wrote:
> Speaking of which, a few of my recent fixes should really go onto the
> patch branch.  Shall I get some approval first?  I'd particularly like
> to apply the anti-truncation fixes in 16890 and users/4678, the unposted
> HISTSIZE-can't-go-below-2 fix, and possibly the latter half of 16703
> (which made the "history" command better in boundary conditions).

It sounds a good idea to me, the problems have been lurking under the
surface for a while.

-- 
Peter Stephenson <pws@csr.com>                  Software Engineer
CSR Ltd., Science Park, Milton Road,
Cambridge, CB4 0WH, UK                          Tel: +44 (0)1223 392070


**********************************************************************
The information transmitted is intended only for the person or
entity to which it is addressed and may contain confidential 
and/or privileged material. 
Any review, retransmission, dissemination or other use of, or
taking of any action in reliance upon, this information by 
persons or entities other than the intended recipient is 
prohibited.  
If you received this in error, please contact the sender and 
delete the material from any computer.
**********************************************************************