From: Michael Hwang <michael.a.hwang@gmail.com>
To: zsh-workers@zsh.org
Subject: [PATCH] Fixed potential crash resulting from bad hash -d.
Date: Fri, 5 Feb 2010 23:52:39 -0500 [thread overview]
Message-ID: <1265431959-13864-1-git-send-email-michael.a.hwang@gmail.com> (raw)
On #zsh, Mikael pointed out that "hash -d fail\\=/tmp" crashes the shell. This patch fixes bad behavior by hash -d if the left hand side of an assignment contains invalid characters.
Michael Hwang
---
Src/builtin.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/Src/builtin.c b/Src/builtin.c
index 1eca820..2a02c9a 100644
--- a/Src/builtin.c
+++ b/Src/builtin.c
@@ -3348,7 +3348,6 @@ bin_hash(char *name, char **argv, Options ops, UNUSED(int func))
"invalid character in directory name: %s",
asg->name);
returnval = 1;
- argv++;
continue;
} else {
Nameddir nd = hn = zshcalloc(sizeof *nd);
--
1.6.2.5
reply other threads:[~2010-02-06 4:58 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1265431959-13864-1-git-send-email-michael.a.hwang@gmail.com \
--to=michael.a.hwang@gmail.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).