zsh-workers
 help / color / mirror / code / Atom feed
* [PATCH] Fixed potential crash resulting from bad hash -d.
@ 2010-02-06  4:52 Michael Hwang
  0 siblings, 0 replies; only message in thread
From: Michael Hwang @ 2010-02-06  4:52 UTC (permalink / raw)
  To: zsh-workers

On #zsh, Mikael pointed out that "hash -d fail\\=/tmp" crashes the shell. This patch fixes bad behavior by hash -d if the left hand side of an assignment contains invalid characters.

Michael Hwang

---
 Src/builtin.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/Src/builtin.c b/Src/builtin.c
index 1eca820..2a02c9a 100644
--- a/Src/builtin.c
+++ b/Src/builtin.c
@@ -3348,7 +3348,6 @@ bin_hash(char *name, char **argv, Options ops, UNUSED(int func))
 				 "invalid character in directory name: %s",
 				 asg->name);
 			returnval = 1;
-			argv++;
 			continue;
 		    } else {
 			Nameddir nd = hn = zshcalloc(sizeof *nd);
-- 
1.6.2.5


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2010-02-06  4:58 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-02-06  4:52 [PATCH] Fixed potential crash resulting from bad hash -d Michael Hwang

Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).