From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28295 invoked by alias); 6 Feb 2010 04:58:56 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 27675 Received: (qmail 28189 invoked from network); 6 Feb 2010 04:58:45 -0000 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VERIFIED autolearn=ham version=3.2.5 Received-SPF: pass (ns1.primenet.com.au: SPF record at _spf.google.com designates 209.85.221.194 as permitted sender) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:to:subject:date :message-id:x-mailer; bh=51zA5dttKaAUkfPwUQ6fdFhQ5sThil6UnJxU1p3Er1A=; b=i0/mSmBtqReb5uMHDW4HXYaYuqLwXcCGb0/MPA2R0alwdKXd7EPduI4Ex/TCH36Rkd EMoFS9HqU52AbRSZqZ5tfPao+SW6j+FiaD0o8fZw6NjmYBQwp2f9nmH2MasXyWzA0apo Q6MJiXI767lusWHHeL9VKUlyQd4/mhajAutds= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:subject:date:message-id:x-mailer; b=p03lPQKqLvi9oMNWl1gB8uBcIFjhbbWksYPBjTF4hJ8abhZ3DGo9uANKRfPHf3jh8g 4H4LsSbRCbG4gZqlAC40DT5gkwHJCWsf8vvb5jgKmMtSJpQrizC6wmPmySOZ3K3A/QU0 wFs+PHUf9d+QMusAcoTpoxGs83e+60zT4uV5w= From: Michael Hwang To: zsh-workers@zsh.org Subject: [PATCH] Fixed potential crash resulting from bad hash -d. Date: Fri, 5 Feb 2010 23:52:39 -0500 Message-Id: <1265431959-13864-1-git-send-email-michael.a.hwang@gmail.com> X-Mailer: git-send-email 1.6.2.5 On #zsh, Mikael pointed out that "hash -d fail\\=/tmp" crashes the shell. This patch fixes bad behavior by hash -d if the left hand side of an assignment contains invalid characters. Michael Hwang --- Src/builtin.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/Src/builtin.c b/Src/builtin.c index 1eca820..2a02c9a 100644 --- a/Src/builtin.c +++ b/Src/builtin.c @@ -3348,7 +3348,6 @@ bin_hash(char *name, char **argv, Options ops, UNUSED(int func)) "invalid character in directory name: %s", asg->name); returnval = 1; - argv++; continue; } else { Nameddir nd = hn = zshcalloc(sizeof *nd); -- 1.6.2.5