* PATCH: vcs_info: Ignore chpwd_functions[] in VCS_INFO_realpath()
@ 2010-03-03 21:06 Frank Terbeck
2010-03-03 21:17 ` Mikael Magnusson
0 siblings, 1 reply; 3+ messages in thread
From: Frank Terbeck @ 2010-03-03 21:06 UTC (permalink / raw)
To: zsh-workers; +Cc: Bart Trojanowski
Spotted and fix suggested by Bart Trojanowski <bart@jukie.net>.
Regards, Frank
---
Functions/VCS_Info/VCS_INFO_realpath | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/Functions/VCS_Info/VCS_INFO_realpath b/Functions/VCS_Info/VCS_INFO_realpath
index c0f48a4..07a9749 100644
--- a/Functions/VCS_Info/VCS_INFO_realpath
+++ b/Functions/VCS_Info/VCS_INFO_realpath
@@ -11,6 +11,7 @@ setopt localoptions NO_shwordsplit
(
(( ${+functions[chpwd]} )) && unfunction chpwd
+ (( ${#chpwd_functions} )) && chpwd_functions=()
setopt chaselinks
builtin cd $1 2>/dev/null && pwd
)
--
1.7.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: PATCH: vcs_info: Ignore chpwd_functions[] in VCS_INFO_realpath()
2010-03-03 21:06 PATCH: vcs_info: Ignore chpwd_functions[] in VCS_INFO_realpath() Frank Terbeck
@ 2010-03-03 21:17 ` Mikael Magnusson
2010-03-03 21:24 ` Frank Terbeck
0 siblings, 1 reply; 3+ messages in thread
From: Mikael Magnusson @ 2010-03-03 21:17 UTC (permalink / raw)
To: Frank Terbeck; +Cc: zsh-workers, Bart Trojanowski
On 3 March 2010 22:06, Frank Terbeck <ft@bewatermyfriend.org> wrote:
> Spotted and fix suggested by Bart Trojanowski <bart@jukie.net>.
>
> Regards, Frank
> ---
> Functions/VCS_Info/VCS_INFO_realpath | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/Functions/VCS_Info/VCS_INFO_realpath b/Functions/VCS_Info/VCS_INFO_realpath
> index c0f48a4..07a9749 100644
> --- a/Functions/VCS_Info/VCS_INFO_realpath
> +++ b/Functions/VCS_Info/VCS_INFO_realpath
> @@ -11,6 +11,7 @@ setopt localoptions NO_shwordsplit
>
> (
> (( ${+functions[chpwd]} )) && unfunction chpwd
> + (( ${#chpwd_functions} )) && chpwd_functions=()
> setopt chaselinks
> builtin cd $1 2>/dev/null && pwd
> )
Why not just use cd -q?
--
Mikael Magnusson
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: PATCH: vcs_info: Ignore chpwd_functions[] in VCS_INFO_realpath()
2010-03-03 21:17 ` Mikael Magnusson
@ 2010-03-03 21:24 ` Frank Terbeck
0 siblings, 0 replies; 3+ messages in thread
From: Frank Terbeck @ 2010-03-03 21:24 UTC (permalink / raw)
To: Mikael Magnusson; +Cc: zsh-workers, Bart Trojanowski
Mikael Magnusson wrote:
> On 3 March 2010 22:06, Frank Terbeck <ft@bewatermyfriend.org> wrote:
[...]
>> (
>> (( ${+functions[chpwd]} )) && unfunction chpwd
>> + (( ${#chpwd_functions} )) && chpwd_functions=()
>> setopt chaselinks
>> builtin cd $1 2>/dev/null && pwd
>> )
>
> Why not just use cd -q?
Good point. `-q' wasn't there when I started vcs_info. :-)
It's the better solution though. I'll send a patch in a minute.
Regards, Frank
--
In protocol design, perfection has been reached not when there is
nothing left to add, but when there is nothing left to take away.
-- RFC 1925
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-03-03 21:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-03-03 21:06 PATCH: vcs_info: Ignore chpwd_functions[] in VCS_INFO_realpath() Frank Terbeck
2010-03-03 21:17 ` Mikael Magnusson
2010-03-03 21:24 ` Frank Terbeck
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).