From: Oliver Kiddle <okiddle@yahoo.co.uk>
To: "Nikolai Weibull" <now@bitwi.se>
Cc: "Zsh Workers" <zsh-workers@sunsite.dk>
Subject: Re: rm(1) completion definition
Date: Wed, 01 Oct 2008 11:38:52 +0200 [thread overview]
Message-ID: <12702.1222853932@dcle12> (raw)
In-Reply-To: <dbfc82860809301403v1ac0eb06ha80f01e96c02ab4f@mail.gmail.com>
Nikolai Weibull wrote:
> 1. It seems that my trick to disable --force and --recursive on
> non-GNU systems doesn't work. Does the specifications have to match
This is better done as:
args=( ${args:#*--(force|recursive)\[*} )
The ! syntax is intended for a different purpose: where you have an
option that may appear earlier on the command-line and you don't want to
complete it but _arguments needs to know what it's exclusion lists and
arguments are.
> 2. I'm not sure if the zstyle thing is correct, but it's definitely
> what you want it to do. Is there a better way to achieve the same
> effect?
The problem with the zstyle stuff is that you've used single quotes so
$curcontext is not expanded. Personally, I think it is fundamentally
wrong to ever define zstyles in completion functions. They are meant
for user-customisation and can sometimes get in the way of
customisations. The very specific context for them can make them hard
to override.
At some point in the past, there was a problem with ignore-line that
meant that if you tried to do something like:
rm foo dir/foo
It wouldn't complete foo in the subdirectory. I can't reproduce this now
so perhaps it was a bit more subtle or perhaps it got fixed.
The right way to do this would be to work out exactly what can't be
completed and build up a suitable glob pattern to pass to _files with
-g.
One other point: I really hope that running rm --version can't possibly
actually result in a file or files being removed on some system. I'm a
bit uneasy about it. Perhaps you should try using rm --help instead
because there's no `r' in help.
Oliver
next prev parent reply other threads:[~2008-10-01 9:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-30 21:03 Nikolai Weibull
2008-10-01 9:38 ` Oliver Kiddle [this message]
2008-10-01 13:21 ` Nikolai Weibull
2008-10-08 9:29 ` Nikolai Weibull
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12702.1222853932@dcle12 \
--to=okiddle@yahoo.co.uk \
--cc=now@bitwi.se \
--cc=zsh-workers@sunsite.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).